Remove 'fivestar_preview' theme function

I've been watching and waiting for this patch for so long. Thank you so much for creating a patch that works!

Hi @init90 - the patch fails when I attempt to apply it via Composer.

I successfully applied the patch to the dev version of the module. Cleared the cache and there was no error message!

Marking as RTBC

Using latest drupal 9.3.x and fivestar @dev module via composer when patching i'm getting this :

https://www.drupal.org/files/issues/2022-04-06/3273701_3.patch (Remove 'fivestar_preview' theme function)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2022-04-06/3273701_3.patch

The patch #3 working for me on 8.x-1.x-dev and Drupal 9.3.13
Thank you so much.

Hey, how do i apply a patch? :(. I am still getting the hang of drupal. in my case i can't use composer so any other method or guide would be helpful.

@AlsammanKhaled - https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...

#3 works

@KarimBou I have the same problem, have you managed to solve it?

@KarimBou and @saesa - be sure to run the patch on the dev version of fivestar.

@Derekb Thank you for the link, I followed the steps and i got this error when trying to apply the patch:
error: corrupt patch at line 72
Im not sure whats wrong but i think there is a missing "}" at the end of the file? not sure.

When will this patch be applied to a release?

Patch #3 worked for me too. Thanks!

Hey All,

I am using the 8.x-1.0-alpha2 version, hence the patch is not getting applied in my case. When can I expect this to be released in the latest version?

@saurabh-2k17 be sure to run the patch on the dev version of fivestar

Confirming #3 is RTBC.

Hi ,
this patch working for 9.x?

Just installed the 8.x-1.x-dev manually patched using #3 on a 9.4.6 site and it works great with no error

Thank you guys, we hope to see this merged soon. thanks

The patch is working fine.

Yeah, we are using it too w/ great success. +1 on commit.

#3 working on a Drupal 9.5

+1 RTBC, #3 works on 9.5.9

Added screenshot with error

Hello.
+1 RTBC, #3 works on 9.5.9

Besides, I have created issue fork and MR with these changes for next release of module.

Bump

I add it to the global issue #3377377 about drupal-check

Remove the function. In the feature, we can always reintroduce it.

I strongly disagree. It should be ported, NOT deleted, because if it deleted it will never be reintroduced. That's what has happened with many other things.

It is really no harder to port it than it is to remove it. This is what the parent META issue is all about.

Throwing away things and taking quick fix shortcuts is one of the reasons this module has deteriorated since D7. If it's important to you, make the small effort to port it properly, don't just throw away what was once working and tested code.

See comments in #3287600-88: Drupal 10 compatibility fixes for what work is remaining here. Basically, we need to figure out if the features are replaced with other theme templates or convert it. I couldn't find where it is used currently, but that doesn't mean it isn't in use. But it doesn't block D10 support.

Reroll patch in #3 to work on the latest dev version for temporary solution

Reroll patch in #36 to work on the latest dev version for temporary solution