[Meta] Replace theme functions with Twig templates

Thank @TR for the nice examples. Here migration of static output function.

Here relevant issues with which I encountered when worked on it: #3142319: Move static theme output into twig templete and #3142322: Attach necessary library for static rating output

Added link to related issue into the patch.

Added related function.

My humble attempt to replace theme functions. Updated fivestar_static_element, fivestar_summary and fivestar_preview_widget functions. I couldn't find where functions fivestar, fivestar_select, fivestar_preview, fivestar_preview_wrapper and fivestar_formatter_default are used. Are they needed at all? Looks like everything is working right now even without them. Maybe someone can point me in the right direction, so when I have free time I can try to update them as well if needed.

Ok fivestar_static theme function is still on '8.x-1.0-alpha2' but not on dev.

It's ok , I missed the fact that the other theme fixes are already on the dev branch and not on the last alpha.
So far dev + patch seems ok.

Hi @TR

I did as requested and made different issue for every theme function, which I was able to replace. Also my previous question still stands: I couldn't find where functions fivestar, fivestar_select, fivestar_preview, fivestar_preview_wrapper and fivestar_formatter_default are used. Are they needed at all? Looks like everything is working right now even without them. Maybe someone can point me in the right direction, so when I have free time I can try to update them as well if needed.

I have tried below patch links through composer but its not working for me..

Patch link: https://www.drupal.org/files/issues/2020-11-21/replace-theme-functions-3...

• The PHP version i am using - 7.4
• Drupal version - 9.2

I am getting below error:
The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-11-21/replace-theme-functions-3...

When I ran "composer update" the inside fivestar module, folder called "b" is there, which includes below twigs:

• fivestar-preview-widget.html.twig
• fivestar-static-element.html.twig
• fivestar-summary.html.twig

Just Update the Patch and remove the commented line.

Meta issues don't have patches so I've hidden them.

Re-rolled the patch

@pbbhoge, Did you not see @TR 's post in #16?

This is a meta issue - patches aren't being evaluated here. Instead, see the related issues in the right sidebar for the issues where the patches are being reviewed. There is one related issue for each theme function.

Please do not upload patches or comment on those already uploaded.

Exported the changes from MR to a static patch file to be able to use it on the project without the risk that it will be changed or removed.

I'm currently reviewing child issue #3186841, but I am missing something or there should be 4 more child ones: theme_fivestar, theme_fivestar_select, theme_fivestar_preview & theme_fivestar_formatter_default ?

Some theme conversions are already done and some were subsumed:

• theme_fivestar -- I think this is used/needed and the earlier patches in this thread include the needed code;
• theme_fivestar_preview is in #3186841, as you know,
• theme_fivestar_formatter_default -- I think there was some discussion about it, but I can't find it now.
• theme_fivestar_select -- I think this is used/needed and the earlier patches in this thread include the needed code;

So I think maybe yes, we are missing one or more child issues.

fivestar_preview has not been removed in #3186841, this issue only deals with fivestar_preview_widget & fivestar_preview_wrapper.

So I will create 4 child issues and try dispatch this issue patches into them.

Ok ?

@O'briat if you are sure the theme functions are not covered in another issue, and are also still required by the module, please do add new issues for them.

Once done, please add the new issues referenced as child issues (that is, in the new issue, reference this one as parent.)

Thanks for your efforts.

Hi,

I looked at the child issues and could not find a solution for: theme_fivestar_select.
I'm using the dev version with the #22 patch from https://www.drupal.org/project/fivestar/issues/3186841.

In fact I still have deprecation messages for all of the following:

• theme_fivestar()
• theme_fivestar_select()
• theme_fivestar_preview()
• theme_fivestar_formatter_default()

One more step forward #3186841: Move preview wigdet theme output into twig template

Added patch after removed all the remaining theme function.

I applied a patch manually reason the patch #25 unable to apply automatically.

In addition to patch, I also faced an issue that I am using layout_builder & star format for rating but if the rating is empty then no field is getting displayed on node view page eventhough field is present in layout. I took a reference of "Fivestar widget not displayed when using Layout Builder" I have added the code and it resolves my issue.

+1 for deprecation message for theme_fivestar_preview after module install via UI or cache clear.

User deprecated function: Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0. Use Twig templates instead of theme_fivestar_preview()

@Nicolas Bouteille any solutions for the issue you faced? I am seeing the same thing on my site after cache-clear.