Problem/Motivation

The theme functions are deprecated in Drupal 9 and will be removed in Drupal 10.
We don't use that function in the last version of the module and for me not clear if it really needed.
The function was added in Drupal 5 and with minimal changes was migrated to D6 and D7.

Function code from D7:

/**
 * Theme the straight HTML version of the fivestar select list. This is used
 * to remove the wrapping 'form-item' div from the select list.
 */
function theme_fivestar_select($variables) {
  $element = $variables['element'];
  element_set_attributes($element, array('id', 'name', 'size'));
  _form_set_class($element, array('form-select'));
  return '<select' . drupal_attributes($element['#attributes']) . '>' . form_select_options($element) . '</select>';
}

Proposed resolution

Remove it now to omit deprecation errors and reintroduce it in the future if someone can explain it's purpose.

CommentFileSizeAuthor
#4 3255948-4.patch1.33 KBinit90

Comments

init90 created an issue. See original summary.

init90’s picture

Issue summary: View changes
alex liannoy’s picture

I barely can imagine someone using this function in D8/D9.
I suggest getting rid of it

init90’s picture

Status: Active » Needs review
StatusFileSize
new1.33 KB

I agree, let's move on:)

init90’s picture

Title: Determine what to do with 'fivestar_select' theme function » Remove 'fivestar_select' theme function

Changed title to more accurate

  • init90 committed 19e5f58 on 8.x-1.x
    Issue #3255948 by init90, Alex Liannoy: Remove 'fivestar_select' theme...
init90’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.