Update the obsolete usage text inside core/scripts/update-countries.sh

Patch #2 cant be applied.Needs reroll.

-congo-kinshasa-3087630-1.patch
Checking patch core/lib/Drupal/Core/Locale/CountryManager.php...
error: while searching for:
      'BZ' => t('Belize'),
      'CA' => t('Canada'),
      'CC' => t('Cocos [Keeling] Islands'),
      'CD' => t('Congo - Kinshasa'),
      'CF' => t('Central African Republic'),
      'CG' => t('Congo - Brazzaville'),
      'CH' => t('Switzerland'),

error: patch failed: core/lib/Drupal/Core/Locale/CountryManager.php:79
error: core/lib/Drupal/Core/Locale/CountryManager.php: patch does not apply

Rerolled patch #2 .Please check.

Looks good.

> The Democratic Republic of the Congo (DRC) (About this soundpronunciation (help·info) French: République démocratique du Congo (RDC) [kɔ̃ɡo]), also known as Congo-Kinshasa

-- https://en.wikipedia.org/wiki/Democratic_Republic_of_the_Congo,

> ISO 3166 code: CD

-- https://en.wikipedia.org/wiki/ISO_3166-2:CD

Per Wikipedia, the change of the name is correct, and the code: CD is unchanged. RTBC+1, also queued tests against 9.2.x, 9.1.x, and 9.0.x branches.

I learned recently that Drupal uses CLDR data for the country list. Is this change in accordance with that?

See #1938892: Switch from ISO-3166-1 country data to CLDR unicode data

Thanks @quietone for sharing the link.

The CLDR data from the latest release of https://github.com/unicode-org/cldr-json/tags still lists the country as Congo - Kinshasa, but looked into the territories.json file inside the folder cldr-localenames-full/main/en, there is an entry "CD-alt-variant": "Congo (DRC)",

On macOS Big Sur (Version 11.3), it lists the country as Congo - Kinshasa too, see the screenshot attached.

The CLDR data should be the source to update the country data and the community agreed before.

So I would suggest updating the script core/scripts/update-countries.sh:

• To use the entry "CD-alt-variant": "Congo (DRC)", instead, per the wiki page mentioned in #10, it looks like more applicable.
• Update the usage part.
  

  - Choose the latest release data from http://cldr.unicode.org/index/downloads
  and download the json.zip file.
  - Unzip the json.zip file and place the main/en/territories.json in the
  Drupal root directory.
  - Run this script.

  The json data link should be download from https://github.com/unicode-org/cldr-json, and the file to place is cldr-localenames-full/main/en/territories.json -- failed to find the json data on http://cldr.unicode.org/index/downloads

Updated the script core/scripts/update-countries.sh and regenerated the file core/lib/Drupal/Core/Locale/CountryManager.php with it.

There are some notes on alternate country names including Congo - Kinshasa at http://cldr.unicode.org/translation/displaynames/country-names

I think there is an issue here in that if we are to change "Congo - Kinshasa" to "Congo (DRC)" then we should also change "Congo - Brazzaville" to "Congo (Republic)" at the same time. But we also need a good reason to change these away from the defaults; we try to be as politically neutral as possible and so we use the CLDR default names for all countries - see also the note on the CLDR page that "The ISO names and the "official" names are often not necessarily the best ones."

Then, only updated the usage part in core/scripts/update-countries.sh.

For the policy of using alt ones, we need to find the opened issue if it exists or file a new one, probably.

Patch #13 and #15 applied cleanly for me.

Applied #8 patch applied successfully
core/lib/Drupal/Core/Locale/CountryManager.php has been modified

Thanks for the patch

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Attached patch against Drupal 10.1.x

Patch #15 is not applied for Drupal 10.1.x so Inter-diff file is not added.

Checking patch core/misc/cspell/dictionary.txt...
error: while searching for:
llamma
lnumber
localemark
localetranslatedirty
localizable
localpath

error: patch failed: core/misc/cspell/dictionary.txt:874
error: core/misc/cspell/dictionary.txt: patch does not apply
Checking patch core/scripts/update-countries.sh...

This needs an issue summary for what is being addressed here. Maybe even a title update to be more clear.

I have created a similar issue to the original issue and noticed the change of CLDR json publishment there:

https://www.drupal.org/project/drupal/issues/3395852#comment-15285830

This is the most recent way to get the json:

- Choose the main branch on repository https://github.com/unicode-org/cldr-json
and download the territories.json file inside the directory cldr-json/cldr-localenames-full/main/en
e.g. https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-locale....

MR created, tests passed.

It’s better if the issue summary could be updated to the issue template just fyi

Issue summary is updated to the issue template.

looks much better to me thanks!

Added some feedback to the MR, hiding the patches as they are not relevant.

Suggestions are applied.

Nice to see this script being updated.

I read the issue summary, which clearly states the problem and solution, and comments and did not find any unanswered questions or work to do. The only thing I see is that the well written release note snippet isn't needed on this issue. But it good practice to write one! Release note snippets will go on the release notes which don't need to mention changes to internal scripts. You can see the types of changes that are put in the release notes by reading the 10.1.0 release notes.

Leaving at RTBC

Good to see the instructions updated. Thanks!

Committed 4c1dbc9 and pushed to 11.x.

I meant to update the tags according to the guidelines.