Hi,

Minor issue on .info.yml file.
WARNING | All dependencies must be prefixed with the project name, for example "drupal:"

CommentFileSizeAuthor
#4 Update_dependencies_format_in_info.yml_2935497-4.patch860 byteschipway
#3 Before_patch.png53.22 KBriddhi.addweb
#3 After_patch.png52.96 KBriddhi.addweb
#2 code-fix-2935497-2.patch375 bytessarguna raj M
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sarguna raj M created an issue. See original summary.

sarguna raj M’s picture

sarguna raj M CreditAttribution: sarguna raj M as a volunteer and at DrupalPartners, Innoppl Technologies Pvt. Ltd commented
Assigned: sarguna raj M » Unassigned
Status: Needs work » Needs review
FileSize
code-fix-2935497-2.patch375 bytes

Create a patch for the same.
Kindly review. :)

riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Reviewed & tested by the community
FileSize
After_patch.png52.96 KB
Before_patch.png53.22 KB

@sarguna raj M, Thanks for the patch, your patch corrects the warning error as per standard. Also, I verify it using Pareview.sh & also checked after before result verification with simplytest.me. PFA screenshots.

chipway’s picture

chipway CreditAttribution: chipway at Chipway commented
Status: Reviewed & tested by the community » Needs review
FileSize
Update_dependencies_format_in_info.yml_2935497-4.patch860 bytes

I think that the patch is not correct as csv_serialization is not in Core, and sub-module exists also. I suggest this patch.

govind.maloo’s picture

govind.maloo CreditAttribution: govind.maloo at Salsa Digital commented
Status: Needs review » Reviewed & tested by the community

Hi
I have reviewed the patch #4 and it's fine.

Thanks

  • jhedstrom committed 79efe34 on 8.x-1.x authored by chipway 
    Issue #2935497 by sarguna raj M, chipway, riddhi.addweb, govind.maloo:...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.