Here's an update of #14 for 1.0. Note, my IDE did some re-formatting on its own, some white spaces have been trimmed, etc.

CommentFileSizeAuthor
#22 maillog-integration.2920034.22.patch19.21 KBKosa Ilma
#21 maillog-integration.2920034.21.patch19.12 KBKosa Ilma
#18 2920034-18.patch20.31 KBKapilV
#17 interdiff.15-16.diff516 bytesmhavelant
#17 maillog-integration.2920034.16.patch20.03 KBmhavelant
#15 maillog-integration.2920034.15.patch20.01 KBmhavelant
#14 2920034-14.patch9.05 KBravi.shankar
#13 2920034-13.patch9.05 KBravi.shankar
#12 2920034-12.patch8 KBravi.shankar
#11 2920034-11.patch3 KBravi.shankar
#9 smtp-mailllog-2920034-9.patch7.74 KBacrollet
#5 smtp_mailllog-2920034-4.patch7.74 KBnicola85
#4 smtp_mailllog-2920034-3.patch7.75 KBnicola85
#2 smtp_mailllog-2920034-2.patch7.19 KBnicola85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nicola85 created an issue. See original summary.

nicola85’s picture

nicola85 CreditAttribution: nicola85 commented
FileSize
smtp_mailllog-2920034-2.patch7.19 KB

Status: Needs review » Needs work

The last submitted patch, 2: smtp_mailllog-2920034-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nicola85’s picture

nicola85 CreditAttribution: nicola85 commented
FileSize
smtp_mailllog-2920034-3.patch7.75 KB
nicola85’s picture

nicola85 CreditAttribution: nicola85 commented
FileSize
smtp_mailllog-2920034-4.patch7.74 KB
acrollet’s picture

acrollet CreditAttribution: acrollet at roomify - online and open source reservation solutions commented
Status: Needs work » Needs review

The last submitted patch, 4: smtp_mailllog-2920034-3.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: smtp_mailllog-2920034-4.patch, failed testing. View results

acrollet’s picture

acrollet CreditAttribution: acrollet at roomify - online and open source reservation solutions commented
Status: Needs work » Needs review
FileSize
smtp-mailllog-2920034-9.patch7.74 KB

re-rolled against HEAD

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer and at City of Oaks Design commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 2 year old patch in #9 no longer applies to 8.x-1.x-dev.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
2920034-11.patch3 KB

I have rerolled.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
FileSize
2920034-12.patch8 KB

Fixed issue with the previous patch.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
FileSize
2920034-13.patch9.05 KB

The last patch was faild so I have created patch again.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
FileSize
2920034-14.patch9.05 KB

The last patch was faild so I have created patch again.

mhavelant’s picture

mhavelant CreditAttribution: mhavelant at Brainsum for Tieto commented
Issue summary: View changes
FileSize
maillog-integration.2920034.15.patch20.01 KB

Status: Needs review » Needs work

The last submitted patch, 15: maillog-integration.2920034.15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mhavelant’s picture

mhavelant CreditAttribution: mhavelant at Brainsum for Tieto commented
FileSize
maillog-integration.2920034.16.patch20.03 KB
interdiff.15-16.diff516 bytes

A use statement for Url was missing in Drupal\smtp\Plugin\Mail\SMTPMailSystem.

Also, as #15 shows, the tests need to be updated.

KapilV’s picture

KapilV CreditAttribution: KapilV as a volunteer and commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2920034-18.patch20.31 KB

Hear a patch updated and fixed coding standards.

Status: Needs review » Needs work

The last submitted patch, 18: 2920034-18.patch, failed testing. View results

KapilV’s picture

KapilV CreditAttribution: KapilV as a volunteer and at Innoraft for Drupal Association, Drupal Care commented
Kosa Ilma’s picture

Kosa Ilma CreditAttribution: Kosa Ilma at Brainsum commented
FileSize
maillog-integration.2920034.21.patch19.12 KB

The last patch failed so I have created a new one.

Kosa Ilma’s picture

Kosa Ilma CreditAttribution: Kosa Ilma at Brainsum commented
FileSize
maillog-integration.2920034.22.patch19.21 KB

The last patch failed on 8.x-1.2 so I have updated it.