Module allows extending Drupal's cache functionality and use it for general caching as well. There are times when we don't really calculate or manage data but they come from 3rd party systems but in order to maintain performance we cache them. These are not really Drupal caches which require cleaning when we clear Drupal caches (drush cr or through interface). I've tried to do minimal code and re-used as much as possible from existing Cache classes to ensure all changes and fixes in core are available to users of pcb asap.

My project page can be found here: https://www.drupal.org/project/pcb

The git clone command would be:

git clone --branch 8.x-1.x https://git.drupal.org/project/pcb.git

Additional info: Since this is really not something Drupal cache is meant for I created a separate contrib module instead of creating feature request in Core.

Comments

nikunjkotecha created an issue. See original summary.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
sleitner’s picture

sleitner commented
Status: Needs review » Needs work

Automated Review

Git errors:

Review of the 8.x-dev branch (commit db36f28):

  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The pcb_memcache.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • The pcb.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • DrupalPractice has found some issues with your code, but could be false positives.
    
FILE: .../pareviewsh/pareview_temp/modules/pcb_memcache/pcb_memcache.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | WARNING | All dependencies must be prefixed with the project name,
   |         | for example "drupal:"
--------------------------------------------------------------------------

Time: 175ms; Memory: 4Mb
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
No: Does not follow the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) delete 8.x-1.0-beta1 branch, https://www.drupal.org/node/1015226

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
Status: Needs work » Needs review

Hi sleitner,

Thanks for the detailed review and putting everything nicely here.

I've tried and addressed all the feedback except one. I couldn't delete 8.x-1.0-beta1 branch as it is tied to a release :(

Let me know if it sounds OK to keep it here as the new release uses 8.x-1.0 tag on 8.x-1.x branch and that branch anyways is not accessible to create a release. I tried to check but seems I can't delete old releases.

Thanks,
Nikunj

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
Issue summary: View changes
sleitner’s picture

sleitner commented
Status: Needs review » Reviewed & tested by the community

Ok, please keep the naming conventions https://www.drupal.org/node/1015226 in mind in the future

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.