[D8] Drupal8 W3CSS Theme

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectd8w3cssgit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@flashwebcenter You indent by 3 spaces instead of 2 in these files.

• config/install/drupal8_w3css_theme.settings.yml
• drupal8_w3css_subtheme/drupal8_w3css_subtheme.info.yml

On line 19 of css/custom/base.css, you prefix max-height with an underscore:
_max-width: 100%;

I'll continue to look through the code for more issues.

Is there a location where more detailed instructions and information regarding this theme are discussed, other than the publicized one at: https://www.drupal.org/docs/8/themes/drupal8-w3css-theme-configuration

which is also at their site:
http://drupal8.w3css.theme.flashwebcenter.com/drupal8-w3css-theme-docume...

Or is there an active forum perhaps?

Original post removed. Opened as issues: Web logo (#2895144) and Colors (#2895145).

Hello again.

I noticed some issues in the drupal8_w3css_theme.theme file mostly regarding readability.

There are numerous long lines full of complex conditional statements. It's difficult to ascertain what's within an AND and what's within an OR. Here's line 23 as an example:

elseif ((!empty($variables['page']['top_first']) && !empty($variables['page']['top_second'])) || (!empty($variables['page']['top_first']) && !empty($variables['page']['top_third'])) || (!empty($variables['page']['top_third']) && !empty($variables['page']['top_second']))) {

Since the !empty checks are performed so often for the same variables, it might be helpful to assign those evaluations to easier-to-read variables as follows:

$has_top_first = !empty($variables['page']['top_first']);
$has_top_second = !empty($variables['page']['top_second']);
$has_top_third = !empty($variables['page']['top_third']));

Then the conditional statement could read:

elseif (($has_top_first && $has_top_second) || ($has_top_first && $has_top_third) || ($has_top_third && $has_top_second)) {

Also, I don't think it's a good idea to evaluate assignments like on line 50:

$my_equal_width = ($variables['equal_width'] = theme_get_setting('equal_width'));

The code will certainly work, but the extra equal signs and parentheses, and the additional overhead for readers to process them, are a hindrance to readability. While there are many alternatives to evaluating assignments, I wonder why it's even necessary to declare $my_equal_width in the first place. Doesn't theme_get_setting return NULL on failure? Such a failure would make $variables['equal_width'] == NULL. Then the conditional on line 51 could instead be:

if ($variables['equal_width'] != NULL) {

Hello. I have a few suggestions below, but didn't notice any major issues so far. Nice work!

Automated Review

https://pareview.sh/pareview/https-git.drupal.org-project-d8w3css.git

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

No: Does not follow the guidelines for 3rd party assets/code.
I recommend removing font awesome fonts and library code from the theme and adding the fontawesome module to the recommended modules section in your readme file.
https://www.drupal.org/project/fontawesome

Or instructions on how to install the fontawesome library when installing the theme.

Same with with w3.css. Since it is 3rd party code you might want to include instructions on how to install it in the libraries directory or consider using a CDN if one is available.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

The README template could be followed to make it more recognizable / easier to read.

This was returned when running pareview.sh:

• Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.

This review uses the Project Application Review Template.

Hi @flashwebcenter,

I have installed your theme, its working fine. No issues have been found in Coder Sniffer. The theme looks good.
Thanks for the theme.

I am re-opening this application, since it has never been approved.

Looks good to me!

Thanks for your contribution, Alaa!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Hello. Love the theme. I have recently ran into an accessibility issue however. When scanning the site with a Deque system (its a university website) I am getting the following critical error - "Ensures elements with an ARIA role that require child roles contain them. Required ARIA children role not present: menuitem menuitemradio menuitemcheckbox." Seems like the error is being thrown on each page by the navigation menu.

• ABOUT

The menu item has a role natively set to "none." Is there an easy workaround for this other than editing the template?

Thank you for any insight you may have - thanks!

@griffin_insight You need to report that in the issue queue for the project. This is the application opened from a user to get the vetted role, not an issue for support requests on the module used for the application.

Hi after I activated this theme, tabs are not displaing sitewide... what would I be doing wrong?