[D8] IPTC media

Hello eliechoufani,

I checked your module, however there are some coding issues and recommendations that you may be interested in :

FILE: /root/repos/pareviewsh/pareview_temp/iptc.module
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
26 | ERROR | [x] A closing tag is not permitted at the end of a PHP
| | file
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Thank you.

Hi eliechoufani,

Kindly see the automated review of your project as I can see some errors.

Link: https://pareview.sh/node/2276

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi eliechoufani,

Automated Review

[Best practice issues identified by pareview.sh]

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.

No duplication
[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch
[Yes: Follows] the guidelines for master branch.

Licensing
[Yes: Follows] the licensing requirements.

3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md
[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
[No: Does not follow] the guidelines for project length and complexity.

Secure code
[No: List of security issues identified.]

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Hello eliechoufani,
Nice module +1. I checked your module with Drupal Best Practice and everything looks good. I tested the module and it works as it says. The module is missing README.txt and it should be good to go.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectiptc_mediagit

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Please refer the below coding standards issues suggested by purview.sh (https://pareview.sh/node/2276)

FILE: .../pareview_temp/config/install/media.type.media_iptc_image_bundle.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
15 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/src/IptcManager.php
--------------------------------------------------------------------------
FOUND 18 ERRORS AND 1 WARNING AFFECTING 14 LINES
--------------------------------------------------------------------------
71 | ERROR | [x] Functions must not contain multiple empty lines in a
| | row; found 3 empty lines
73 | ERROR | [ ] More than 2 empty lines are not allowed
241 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 7
242 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 8
243 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
243 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
243 | ERROR | [x] No space found before comment text; expected "// $x1
| | = str_replace("public://",
| | "http://localhost/iptc-on-84/sites/default/files/",
| | $file->getFileUri());" but found "//$x1 =
| | str_replace("public://",
| | "http://localhost/iptc-on-84/sites/default/files/",
| | $file->getFileUri());"
244 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
244 | ERROR | [x] No space found before comment text; expected "//
| | $info = [];" but found "//$info = [];"
245 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
245 | ERROR | [x] No space found before comment text; expected "//
| | $size = getimagesize($x1, $info);" but found
| | "//$size = getimagesize($x1, $info);"
245 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
246 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
247 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
248 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
249 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
| | 11
399 | ERROR | [x] Closing brace indented incorrectly; expected 11
| | spaces, found 8
400 | ERROR | [x] Closing brace indented incorrectly; expected 10
| | spaces, found 6
401 | ERROR | [x] Closing brace indented incorrectly; expected 8
| | spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/iptc.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/iptc.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
14 | ERROR | [x] No space found before comment text; expected "//
| | print_r($form_id);" but found "//print_r($form_id);"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.