[D7] TableField Extended

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please update git url

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/bojan_m/2839461.git

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxbojan_m2839461git

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

i found bug on field settings page when I want to change number of rows/columns I get ajax error you can see in the attached image.
I was install clean drupal and your module using default theme.

Hi bojan_m,

Do at least 3 manual reviews of separate project applications for "PAReview: review bonus".
Please read the review bonus page again https://www.drupal.org/node/1975228

Hi bojan_m

I have the following observations:

a) The variable tablefield_extended_csv_separator is being deleted in hook_uninstall, but this variable doesnt appear to be set nor get anwhere else in the module.
b) A implementation of hook_help() could add to the documentation visibility.

Kind regards

Andy

Hi bojan_m,

While reviewing your code i found some warnings:
a) Going to save node witout filling any values in table http://www.screencast.com/t/TgSDcen42M
a) After adding a node without filling the values in tables i got some warnings like http://www.screencast.com/t/i42br0GUa
b) By adding a line of code this warning will be removed like http://www.screencast.com/t/Pl3JgmntLtK

Kind regards
Satyam

Automated Review

https://pareview.sh/node/599 Found these two warnings, which you should consider fixing.

FILE: /root/repos/pareviewsh/pareview_temp/tablefield_extended.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
490 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
843 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
--------------------------------------------------------------------------

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

1. Fix those two warnings if possible, but it's not necessary.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

manual review:

1. _notes folder: what is that used for? Maybe from your editor? I think this should be removed from the git repository.
2. "$form_state['clicked_button']['#value'] == 'Add new row'": this will not work when the button label has been translated, right? So this should be wrapped in t()?

Otherwise looks good to me.

Thanks for your contribution, Bojan!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Module duplication:
See https://www.drupal.org/node/2816955#comment-11936786 (#2816955: Insert/delete columns).

I invite the maintainer to solve that issue.