getDisplay() on null Entity Browser reference

That would definitely improve usability and prevent confusion. Let's do this.

Not sure if form_alter is the only way of adding our validation logic to entity form displays... but couldn't find another way of doing it. Will appreciate feedback.

Hi and thank you for creating this issue.

I had the same issue with a custom entity containing an Entity Browser which has been deleted.

I propose to simply try to NOT getDisplay() but to replace the $element['entity_browser'] by an error message.

I like the approach in #4. I think that we should also show the name of the missing EB in the error message.

Patch violates few coding standard rules. Would be great to run it through CodeSniffer.

Thank you for your review @slashrsm

I've run CodeSniffer on my code and I've regenerated a patch.

Hopefully it is compliant with coding standard rules now.

Couldyou apply this plz. got the error and it drives me crazy

I did not have any media on the a image field and configured it to use entity_browser
but then no node would be able to be edited (500 error on node/xx/edit)

patch in # applied cleanly

cd modules/entity_browser
wget https://www.drupal.org/files/issues/ElementPatch_0.patch
git apply -v ElementPatch_0.patch

and now I can edit the nodes again

EDIT: Turns out I did not have "entity browser" selected but still should not give me such error

Go to 'Manage form display' of your content type and re-save image widget settings, it helps me with the same error

Thank you :)

The problem is still relevant. Patches do not solve it.
After applying the patch, when creating the material, I see the inscription - "Entity browser not found".

@Enaj check my comment #10, maybe this will help

@hamrant I tried, it did not help.

@hamrant You were right, your advice helped. The first time I changed the display settings and not the field settings.

Updated the patch for entity browser 8.x-1.0

The patch in #17 didn't work, since some of the rows were left outside the if(). Attached is a fixed patch, which is a re-roll of the patch in #6.

#19 worked like a charm for me. Thank you @ZeiP

#19 works great. Can we have a new release soon please, which contains this fix? That would be very very helpful.

I think the element should still return _something_, even if the Entity Browser doesn't exist. There should be a message of some kind that informs them that the form configuration is invalid, or that the Entity Browser doesn't exist. Seeing nothing doesn't inform users that there's a problem.

Given patch was not applying on version entity_browser 8.x-1.1.
Added updated patch for this version.

#19 worked fine here as well. Any plans to a new release?

Thanks

I think my review from #23 missed the markup text that informs users that the Entity Browser doesn't exist, sorry about that! Once a new patch is re-rolled we can put the issue back in RTBC.

The patch applies just fine against 8.x-1.x HEAD, it was the 8.x-1.1 release that required a changed patch. As the patch applies, I'm changing the issue to RTBC per @samuel.mortenson's suggestion. Thanks!

Few minor fixes.

Committed. Thanks!

After i applied the patch #29 i got another error:

Fatal error: Using $this when not in object context in ... modules/entity_browser/src/Element/EntityBrowserElement.php on line 171

I tried in a field in form display and i got this error. In the editor it works fine.

Hi,

Error found on #32 has been fixed in this issue : https://www.drupal.org/node/2909945#comment-12264581