[D8] Page Layout

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

http://pareview.sh/pareview/httpgitdrupalorgsandboxkaa4ever2811171

[
- Git default branch is not set, see: https://www.drupal.org/node/1659588
- README.md - lines exceed 80 lines, minor formatting, not critical.
- Dozens of warnings across most files. Lots of "Missing class doc comment" and "Missing short description in doc comment" ad other comment warnings.
- Multiple warnings of: "Only string literals should be passed to t() where possible"
]

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[No: Causes] module duplication and/or fragmentation.
It has a almost identical interface and functionality to Page Manager. Likely to cause future fragmentation with that module.

Master Branch

[No: Does not follow] the guidelines for master branch. See pareview above.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) The administration interface seems to work okay and is well written. However, I can't get past the "Place block" button Nothing happens when I click it. Documentation failure?

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I tracked the error down in my previous comment under Coding style & Drupal API usage 1.

Recoverable fatal error: Argument 5 passed to Drupal\block\Controller\BlockLibraryController::__construct() must be an instance of Drupal\Core\Routing\RedirectDestinationInterface, none given, called in /page_layout/src/Controller/BlockController.php on line 44 and defined in Drupal\block\Controller\BlockLibraryController->__construct() (line 71 of /core/modules/block/src/Controller/BlockLibraryController.php)

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2827253

Project 2: https://www.drupal.org/node/2813343

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.