Description

This module integrates heidelpay's redirection payment service with Ubercart to allow users to pay via credit card.

Other modules

There is no module for heidelpay and Ubercart existing yet.

Project link

https://www.drupal.org/sandbox/gruberroland/2772263

Git

git clone git://git.drupal.org/sandbox/gruberroland/2772263.git uc_heidelpay

Manual reviews of other projects

Comments

gruberroland created an issue. See original summary.

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxgruberroland2772263git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

gruberroland’s picture

Status: Needs work » Needs review

Fixed all pareview.sh issues.

gruberroland’s picture

Issue summary: View changes
gruberroland’s picture

Issue summary: View changes
bubu’s picture

Issue summary: View changes
Status: Needs review » Needs work

Hi,

1. I corrected the git clone command in the summary.
2. There are too much issues with code standards. Please, correct them first: http://pareview.sh/pareview/httpgitdrupalorgsandboxgruberroland2772263git

gruberroland’s picture

Status: Needs work » Needs review

Thanks for the hint, seems that the pareview rules were extended. All issues are fixed now.

3ssom’s picture

Status: Needs review » Reviewed & tested by the community

Automated Review

Looks good :)

Manual Review

Individual user account
[Yes: Follows / No: Does not follow] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause / No: Causes] module duplication and/or fragmentation.
Master Branch
[Yes: Follows / No: Does not follow] the guidelines for master branch.
Licensing
[Yes: Follows / No: Does not follow] the licensing requirements.
3rd party assets/code
[Yes: Follows / No: Does not follow] the guidelines for 3rd party assets/code.
README.txt/README.md
[Yes: Follows / No: Does not follow] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
[Yes: Follows / No: Does not follow] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements. / No: List of security issues identified.]
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. Perhaps you should give the README file little afford there ,, lose the hashtags with underline for every section I think it will look much better for the eye.

I'm putting this as RTBC!

apaderno’s picture

Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

I will update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.

gruberroland’s picture

Thanks, updated the Readme. :)

3ssom’s picture

Great and congrats for the full project ... keep up the good work :)

gruberroland’s picture

Status: Fixed » Closed (fixed)
apaderno’s picture

Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.