[D7] Localist Calendar for Drupal

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxlocalist2784539git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

1) In js folder, for localist.js use:

Drupal.behaviors.localist= { attach: function (context, settings) { //logic }}

Refer : JavaScript coding standards

2)readme.txt file should be renamed by README.txt or README.md

Hi,

Please see my comments below.

Automated Review

Fix the issues mention in automated review.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

No: Does not follow the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

No: List of security issues identified.

1. (*) localist_menu(): the page callback is unprotected. You are setting 'access callback' as TRUE for admin urls. Configuration pages can be accessible by anonymous users. This is a security issue.

Coding style & Drupal API usage

1. All user facing text should pass through t() function. Found below in localist.module.
   

   		  $form['header_fieldset']['header_markup0'] = array(
   		    '#type' => 'markup',
   		    '#prefix' => '<div class="wrape_container"><h4 style="border-bottom: 1px solid #bebfb9; padding-bottom: 5px;">Widget Builder</h4>',
   		  );
   		  .
   		  .
   		  .
   		  $form['config_fields'] = array(
   		    '#type' => 'markup',
   		    '#prefix' => '<a href="javascript:void(0)" class="button" id="config-localist-fields">Configure Block </a>'
   		  );
   		

2. Use drupal_http_request() instead of curl() in your code. Found
   

   		  $ch = curl_init();
             curl_setopt($ch, CURLOPT_URL, $url.'organizations'.$q);
   		  curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
   		  $str = curl_exec($ch);
   		  curl_close($ch);
   		

3. Use MENU_LOCAL_ACTION in hook_menu to add action links at top of listing page.
   Found

   		  $form['edit_block_markup']  = array(
           	'#type' => 'markup',
   	        '#prefix' => '<ul class="action-links"><li><a href="'.$base_url.'/admin/config/system/localist">Create New Block</a></li></ul><h4 style="border-bottom: 1px solid #bebfb9; padding-bottom: 5px;">Update Block Configurations</h4><table id="blocks" class="sticky-enabled tabledrag-processed tableheader-processed sticky-table"><thead><tr><th> Block Name </th><th> Operations </th></tr></thead><tbody>'
   	      );
   		

   Refer http://drupal.stackexchange.com/questions/55171/how-should-i-define-a-me...

4. Use Drupal JavaScript behaviours in your custom js file localist.js. Refer Managing JavaScript in Drupal 7
5. Use Drupal.t() to transcilate strings in JavaScript. Refer Translating strings in JavaScript

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thanks,
ARUN AK

Hi,
We are able to see README-file as readme.txt.
Kindly refer the attached screenshot.
Thanks.

HI @localist
1) I suggest in your .install file in hook_uninstall() to remove your custom table(localist_blocks_data) if the module is removed.

hi @localist
It is good you have the uninstall hook. However there is a better way to remove the your custom table explitily by using drupal_uninstall_schema in uninstall hook.
https://api.drupal.org/api/drupal/includes%21common.inc/function/drupal_...

Hello localist,

No nothing is fixed ,, please see #7 by ARUN AK and note by Hardik_Patel_12 for using uninstall hook to delete schema table(localist_blocks_data) in #13.

Thank you

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Please do not assign ticket yourself. Please see the workflow https://www.drupal.org/node/532400

Just an FYI, since #2666576: Allow non-git vetted users to promote sandbox projects to full project status all users have been able to promote projects without PAR. We're evaluating this service at the University of Colorado, but would like to see an integration with 1.0 release that is opted into security coverage.

@localist,

Kindly fix your https://pareview.sh/node/2007 it's long list of issue so i am adding only once screenshot that i taken in one time.

Regards
Satyam

@Satyam Upadhyay That type of comment isn't constructive and discourages new developers from contributing. This developer/team or developers from a vendor is trying to maintain their own project on Drupal.org. They were able to get a Localist plugin published to https://wordpress.org/plugins/localist-calendar with much less hassle.

There are several issues with this project/code, but most of the errors pareview.sh is complaining about is based on confusion about what the project machine name should be vs. the module name. There are still issues even after changing the project name and applying #2884148: Fix directory structure, but please try to offer new developers constructive advice instead of just posting " fix your code".

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.