"MIME file validator" validates file type on server side. This is simple module. In drupal 7, files validate only on file name extension.
This module is dependent on "fileinfo" php library.

Please review this module for transfer from drupal sanbox project to drupal fullproject.

Gir clone URL:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/sujay.php/2781153.git mime_file_validator
cd mime_file_validator

sandbox project link-
https://www.drupal.org/sandbox/sujayphp/2781153

Comments

sujay.php created an issue. See original summary.

panshulk’s picture

Hi @sujay.php

Can you please provide the git URL and Installation instructions for the Module?
and also please provide the git sandbox URL, so that the automated review can be carried out.

thank you :)

panshulk’s picture

Automated Review

Automated Review Failed , check here

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Please refer the templates to revisit the Readme file.

Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements. / No: List of security issues identified.]
Coding style & Drupal API usage
  1. In mime_file_validator.module there are multiple if else iterations written, Can this be handled by Switch Case , to give a better Structure to the Code? Or is there any specific reason to write it in the way as it is written as of now

This review uses the Project Application Review Template.

panshulk’s picture

Status: Needs review » Needs work
dilipsingh02’s picture

Priority: Critical » Normal
Issue summary: View changes
sujay.php’s picture

Priority: Normal » Major

I have executed git command for clone-
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/sujay.php/2781153.git

Please review this

sujay.php’s picture

Status: Needs work » Needs review

Issue fixed please review.

panshulk’s picture

Status: Needs review » Needs work

Good work @sujay.php :)

Also please look into the indentation and coding standards issues of the code, since PAreview is unable to report any errors/ Coding standard issues.

You can install Coder sniffer on your local machine and check for all coding standard and indentation issues, check the installation process here.

thank you :)

sujay.php’s picture

Status: Needs work » Needs review
sujay.php’s picture

StatusFileSize
new25.19 KB
PA robot’s picture

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2781175

Project 2: https://www.drupal.org/node/2774629

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

sujay.php’s picture

Priority: Major » Critical
yogeshmpawar’s picture

Title: MIME file validator » [D7] MIME file validator
arun ak’s picture

Found a similar projects already available in drupal.org;

  1. File Upload Secure Validator
  2. MimeDetect

Also found one more application in the queue which is providing the same feature, [D7]File Mime Type Checker.

Please include how your module is different from existing modules and mention similar projects in project page or else try to contribute to those existing modules.

Thanks,
ARUN AK

djalxs’s picture

Status: Needs review » Needs work
kattekrab’s picture

@sujay.php - You can now promote this to a full project yourself.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

avpaderno’s picture

Assigned: sujay.php » Unassigned
Priority: Critical » Normal