[D8] Userium

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxuserium2774611git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

Individual user account

Yes

No duplication

Yes

Master Branch

Yes

Licensing

Yes

3rd party assets/code

Ideally, Bootstrap would be included via CDN in a userium.libraries.yml file, rather than be distributed with the theme itself. Something like:

global-css:
  css:
    theme:
      //fonts.googleapis.com/css?family=Oswald:400,700: { type: external }
      css/style.css: {}
      https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css: { type: external, minified: true }
      https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap-theme.min.css: { type: external, minified: true }

global-js:
  js:
    js/bootstrap.js: {}
    https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js: { type: external, minified: true }
  dependencies:
    - core/jquery

That would eliminate any Parareview errors coming from the local copy.

README.txt/README.md

Yes

Code long/complex enough for review

Yes

Secure code

Yes

Coding style & Drupal API usage

Not sure what the "sass" and "templates" files are supposed to be, but they are large files that don't seem to serve any purpose ... ? Are those supposed to be folders or something?

Looks good! Setting to Reviewed...

No problem! If you have a moment, I would love a review of my menu_markup module! It's simple, and small, and should be easy to look at :D

https://www.drupal.org/node/2782259

Cheers.

Thanks for your contribution, userium!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.