Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jun 2016 at 12:21 UTC
Updated:
3 Feb 2017 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
dilipsingh02 commentedAutomated review
http://pareview.sh/pareview/httpsgitdrupalorgsandboxmartin2366367git
please fix following issues :
FILE: /var/www/drupal-7-pareview/pareview_temp/bdlf.module
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
131 | ERROR | [x] Expected one space after the comma, 0 found
131 | ERROR | [x] Expected one space after the comma, 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Comment #4
Martin. commentedFixed
Comment #5
andrey.troeglazov commentedHello,
I`ve reviewed your module, there are some issues:
1) Readme file is not correct. Please, make it according specifications. https://www.drupal.org/node/2181737
2) You don't have hook_help. Please check it. https://www.drupal.org/node/1095546
3) Unnecessary space http://storage2.static.itmages.com/i/16/0617/h_1466170429_7677515_a857ff...
4) Codestyle http://storage7.static.itmages.com/i/16/0617/h_1466170625_1534608_fd2094...
Kind Regards.
Comment #6
andrey.troeglazov commentedComment #7
klausiStyle issues alone are surely not application blockers, anything else that you found or should this be RTBC instead?
Comment #8
viljaste commentedComment #9
arvind.kinjaYou should add dependencies for entity module in info file.
Comment #10
arvind.kinjaComment #11
Martin. commentedCould you elaborate on that arvind.kinja ? This module does not depend on entity or any other module.
Comment #12
arvind.kinjaYou are using entity_metadata_wrapper() function on your module that is defined in entity module. If you will not use this module then you will got error Fatal error: Call to undefined function entity_metadata_wrapper() in /home/arkmwdemoserver/public_html/drupal7test/sites/all/modules/bulk_download_field_formatter/bdlf.module on line 64
Comment #13
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #14
Martin. commentedFixed all the above mentioned problems.
Comment #15
viisut commentedComment #16
visabhishek commentedI am getting WSOD while i am trying to download files using your module.
Please see the Module Configuration in attached screenshot.
Error log message is :
[Wed Jan 18 23:48:30.347199 2017] [:error] [pid 3928] [client 127.0.0.1:59858] PHP Fatal error: Class 'ZipArchive' not found in /var/www/html/drupal-7.51/sites/all/modules/bulk_download_field_formatter/bdlf.module on line 102, referer: http://localhost/drupal-7.51/node/4Please let me know if i am missing anything.
Comment #17
Martin. commentedYou don't have PHP zip extension loaded and this is what is causing the error. I have implemented hook_requirements() which will check the presence of the extension and will return error status when it's missing which should result in module failing to install or when it's already enabled there is a status row about the availability of the extension on status report page (/admin/reports/status)
Comment #18
poojasharmaece commentedLooks all good. Working Fine for me.
Comment #19
visabhishek commentedReview of the 7.x-1.x branch (commit 161a622):
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
Please resolve following issues .
Otherwise all looks good for me.
Thanks for your contribution, Martin!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.