Add README.txt to Seven theme

Attached is the patch with the README.txt file.

+++ b/core/themes/seven/README.txt
@@ -0,0 +1,41 @@
\ No newline at end of file

Patch #3 applies clean.README file has good information.
There should be an extra new line at the end.
It would be good if we could add a README.txt to Drupal 7 also.

Added new line at the end of code.

Thanks!!

Given information in README.txt file is nice and patch works for me passing this.

The test is passing in PHP 5.6 & MySQL 5.5 18,519 pass.

Thanks!!

Adding this as reviewed because the patch is passing in PHP 5.6 & MySQL 5.5 18,519.

I'm not sure about the amount of information in this file. For example, explaining sub theming seems OTT - also seven is marked @internal so encouraging sub themes seems a bad idea.

Assigning to Cottser for review.

Hi,
Please find the updated patch which contains the README.txt file for the seven theme of Drupal 8.

Thanks,

Plesae find the updated patch 16.

Adding fresh patch Please review this if it got passes :) ...

There are some layout issues:

1. +++ b/core/themes/seven/README.txt
   @@ -0,0 +1,42 @@
   +Seven is the default administration theme for core in Drupal 8. This theme appears to
   +those administering Drupal on all admin pages and by default to those adding the
   +content.
   +
   

   This paragraph exceeds 80 columns.

2. +++ b/core/themes/seven/README.txt
   @@ -0,0 +1,42 @@
   +See https://www.drupal.org/theme-guide/8 for more information on Drupal 8 theming.
   

   So does this one.

3. +++ b/core/themes/seven/README.txt
   @@ -0,0 +1,42 @@
   \ No newline at end of file
   

   There is no newline at the end of the file.

adding patch with following changes said in # 20

Added an extra return line at the bottom ones.

Thanks for the work so far everyone.

1. +++ b/core/themes/seven/README.txt
   @@ -0,0 +1,45 @@
   +appears tothose administering Drupal on all admin pages and by default to those
   +adding the content.
   

   "tothose" - typo. But it's also very passive voice, what about something more along the lines of "This theme is used on all admin pages and by default on node edit forms."

2. +++ b/core/themes/seven/README.txt
   @@ -0,0 +1,45 @@
   +It is a clean, safe, and stable theme with minimal colors and branding that can
   

   If it's internal is it really also stable? It can change.

3. +++ b/core/themes/seven/README.txt
   @@ -0,0 +1,45 @@
   +be easily used to administer Drupal.
   

   Not sure about the "easily used to administer Drupal" part, maybe we can replace stable with usable if we think that's one of its qualities.

4. +++ b/core/themes/seven/README.txt
   @@ -0,0 +1,45 @@
   +To read more about the Seven theme's origins (in D7) please see:
   

   D7 is jargon, let's at least replace this with Drupal 7.

5. +++ b/core/themes/seven/README.txt
   @@ -0,0 +1,45 @@
   +ADDING A SUBTHEME TO SEVEN
   

   I agree with @alexpott we should not describe how to create a Seven subtheme because it's actively discouraged.

Overall I'm not sure about including all this in the README, I think it'd be preferable to ensure we have good documentation for these points that are not Seven-specific on drupal.org and link to them rather than including them here.

As per the Cottser comments, i have made the readme file small and simple.

Made the changes as per Cottser suggestion in #24.

Like I wrote in #2749901: Add README.txt to Bartik theme, I don't see why we would want to document how to change the admin theme in the README for a specific theme. I've removed that from the issue summary.

+++ b/core/themes/seven/README.txt
@@ -0,0 +1,16 @@
+It is a clean, safe and usable theme with minimal colors and branding.

I have no idea what "safe" and "usable" mean here. Safe, for what purpose? Are other themes "unusable". Ha, maybe...

Removed the text from https://www.drupal.org/node/2725039#comment-11898607, also added a link to the theme page on drupal.org, like it is in Bartik

Applied the patch

I'm working on this today at DrupalCon.

I've tested this. It's applied correctly.
Screenshot attached.

I mentored @mttsmmrssprks and saw the patch apply correctly and then re ran locally and it worked as intended as per screenshot.

Thanks @aburrows and @mttsmmrssprks!

In this case, a screenshot of applying the patch isn't needed. The automated testing infrastructure (a.k.a. "testbot") checks for us whether or not the patch applies. For this issue, let's review the content of the text added, and see if it seems complete and correct. We can also compare it to other READMEs that have been added.

+++ b/core/themes/seven/README.txt
@@ -0,0 +1,17 @@
+See https://www.drupal.org/theme-guide/8 for more information on Drupal 8
+theming.
\ No newline at end of file

Oh, also! Let's make sure to add a single newline to the end of the file to comply with our coding standards. Thanks!

Thanks @aburrows and @mttsmmrssprks! for this patch.
Thanks @xjm for reviewing this patch I have addressed #40 #41 and #42 and readme_file_seven_theme-2725039-42.patch looks final and complete and is ready for review.
Comparing this README to READMEs that have been added this content looks good.

I have tested the #43 patch and it's applied cleanly. Attached the screen shot.

Testbot Snafu.

Should we mention in the README.txt that Seven is internal theme and shouldn't be extended by other themes?

Good suggestion @lauriii, I've added it to the patch including a link to the change record #2582945: Seven is now internal and will change in minor versions

Created a patch and interdiff

Patch in #48 addresses @lauriii's point from #47, that part's good.

The D8 theme-guide URL gets a 301 redirect though, i.e.
https://www.drupal.org/theme-guide/8

301 redirects to ...
https://www.drupal.org/docs/8/theming

The latter URL is the one mentioned by the README recently added to Bartik. I think this was likely part of the plan to re-organize the handbook on d.o

Can we update this URL in the Seven README too please?

Updated the patch with the changes suggested by Andrew.

Edited theme-guide URL in patch #48.
Thanks @andrewmacpherson for noticing it.

Thanks @brentgees and @manish-31. The patches in #50 and #51 are the same, and fix the redirected URL noted in #49.

There's another one though.

https://www.drupal.org/documentation/themes/seven.
redirects to:
https://www.drupal.org/docs/7/core/themes/seven

It looks like another one from reorganizing the handbooks. I've updated it in a patch here. Now all the URLs in the README are the current ones, avoiding redirects.

Thanks @andrewmacpherson, I've noticed the duplicate in #50 and #51 as well, pretty funny two identical patches so short after each other :)

I think the file looks good now, I don't notice any mistakes anymore.

Adjusting credits.

Committed b91f5b4 and pushed to 8.6.x. Thanks!