[D8] Trance

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxpolynya2717989git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

You can use an indent of 4 spaces for composer.json

 {
-  "name": "drupal/trance",
-  "type": "drupal-module",
-  "description": "Translatable Content Entity",
-  "keywords": ["Drupal"],
-  "license": "GPL-2.0+",
-  "homepage": "https://www.drupal.org/sandbox/polynya/2717989",
-  "minimum-stability": "dev",
-  "support": {
-    "issues": "https://www.drupal.org/project/issues/2717989",
-    "source": "https://www.drupal.org/sandbox/polynya/2717989"
-  },
-  "require": { }
+    "name": "drupal/trance",
+    "type": "drupal-module",
+    "description": "Translatable Content Entity",
+    "keywords": ["Drupal"],
+    "license": "GPL-2.0+",
+    "homepage": "https://www.drupal.org/sandbox/polynya/2717989",
+    "minimum-stability": "dev",
+    "support": {
+        "issues": "https://www.drupal.org/project/issues/2717989",
+        "source": "https://www.drupal.org/sandbox/polynya/2717989"
+    },
+    "require": {}
 }

Changing status to Needs Review

Hi @polynya

There are few Warnings and Coding standard errors reported by pareivew.sh, please resolve the issues reported :)

Automated Review :

http://pareview.sh/pareview/httpsgitdrupalorgsandboxpolynya2717989git

Automated Review

Reported false positives by pareview.sh:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxpolynya2717989git-8x-1x
The t( functions are called properly.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause moduleduplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. TranceAccessControlHandler has the feature envy code smell. However this is not preventing the project to be approved.
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

Thanks for your contribution, polynya! You are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process, and especially my slowness in approving after review. We know it's broken and are trying to fix it.

Hi mlncn,

I think you forgot to change the status.