[D7] Track Username

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I have just seen your code manually, although it looks OK except following:

1. hook_help() is absent, its not required but good to have.
2.

track_username.admin.inc

Line 15: use <br /> instead of <br>
'#description' => t('Limit the tracked username history per user. Leave empty for unlimited (not recommended).<br>WARNING: changing this value will delete all existing tracked usernames!!!'),

more to come later...

Hi
It looks really nice and clean code with proper documentation. I would really like to have few more things in the module.

- it would be nice to have a subtab in user profile page so that you can see the history of username. It might be really helpful.
- This kind of features it is very good to have a permission string so other roles of user can access, edit or delete it. you can do it using the hook_permission() function.
- May be really nice to have a settings for user to control the limit (But definitely have maximum limit ). I know your module is needed for admin but for social site this feature could be very cool.

Otherwise no coding issue i found and looks good to me.

Hi firewaller,

I just gone through your module quickly and I must say immaculate code has been written in module

Here are some points from my side

1. In hook_help, change its URL it must be something like

admin/help#{module_name}
In you case
admin/help#track_username

If hook_help is correctly implemented then you can see help link in module page same as configuration link and write something about your module just like you describe in README file, For help you can see core module file like block.module

2. You are using db_insert to insert your value in custom table instead of db_insert use drupal_write_record It will give more readability to your code and it's also good to use Drupal API.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Please resolve the coding standard errors http://pareview.sh/pareview/httpsgitdrupalorgsandboxfirewaller2676004git

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.

Coding style & Drupal API usage

No issues found

@shkiper: minor coding standard problems are not application blockers, anything else that you found or should this be RTBC instead?

@klausi no other issues found. Modules works as described on the sandbox page

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.