If you have an online store on CMS Drupal, then you need a module payments for orders made. This will help you plug the payment system Wallet One. With our system you will be able to significantly expand the method of receiving payment in many countries. We have about 100 method payment.

Git clone command:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/h_elena/2636118.git w1_drupal-commerce

Project:
https://www.drupal.org/sandbox/h_elena/2636118

Comments

h_elena created an issue. See original summary.

WalletOne’s picture

Status: Active » Needs review
PA robot’s picture

Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxh_elena2636118git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

WalletOne’s picture

Status: Needs work » Needs review

Hello. All errors fixed.

jlicht’s picture

Status: Needs review » Needs work

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: Does not cause module duplication and/or fragmentation.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.

[+] Module documentation should be included in the Readme.txt file, not, in a PDF
[+] All documentation must be in English (see https://www.drupal.org/node/161085)

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements. / No: List of security issues identified.

Coding style & Drupal API usage
[-] L89-96 - I believe these should be in English

klausi’s picture

Status: Needs work » Needs review

The documentation improvements are surely not application blockers, anything else that you found or should this be RTBC instead?

jlicht’s picture

Status: Needs review » Reviewed & tested by the community

Documentation issues were all that I found. Setting to RTBC as per comment by klausi

WalletOne’s picture

Translation will be, but later.

WalletOne’s picture

Issue summary: View changes

Adding translation for english version

WalletOne’s picture

Issue summary: View changes
mlncn’s picture

Looks all right. The module will need to be de-nested, to put it at the top level (the numeric 'name' will be replaced with your project name when you can promote it). The read.pdf file should be removed from the repository, and hosted externally (especially since it is not in English).

mlncn’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

gisle’s picture

Status: Fixed » Needs work

While this one somehow got approved, it still fails on one of the main points on the review checklist.

The directory http://cgit.drupalcode.org/sandbox-h_elena-2636118/tree/w1_drupal_commer... in the project repo is full of 3rd party company logos that is both copyrighted and trademarked. Don't even dream about licensing this intellectual property belonging to various third parties under the GPL.

3rd party assets/code
No: Does not follow the guidelines for 3rd party assets/code.

Our policy on 3rd party materials in the repo is described in the 3rd party libraries and content on Drupal.org. It also appears in the Drupal Git Repository Usage policy you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

Master Branch
No: Does not follow the guidelines for master branch. The default branch is set to 7.x-1.1.4, not 7.x-1.x.
gisle’s picture

Assigned: WalletOne » Unassigned
Issue summary: View changes

Added link to git clone command and project.

gisle’s picture

Status: Needs work » Fixed

Klausi has requested that I put the status of this one back to "Fixed" and pursue the copyright violation in the project's own issue tracker.

However, as a spurious reviewer, I must admit that it surprised me to see that this particular application became approved. I haven't taken the time to do a real review, but would like to point out the following pecularities to those who reviewed (and finally approved) this application:

  • Blatant copyright violations in directory: http://cgit.drupalcode.org/sandbox-h_elena-2636118/tree/w1_drupal_commer...
  • In README.md, it is stated that the project's license is GPLv3 (not compatible with GPLv2+). I believe Licensing is the fourth item on the review checklist.
  • The default "branch" for the repo is set to 7.x-1.1.4. It looks to me as if the author doesn't know the difference between a branch and a tag in git.
  • There is no code in the topmost directory of the repo.
  • The README is very skimpy, but says: "Instructions for configuring the plugin is in the file read.pdf." (which is a six page PDF in russian).
  • The user interface is a mix of English and Russian.
  • The author doesn't know that localize.drupal.org is the place to translate a module (and supplies a Russian .po file).
  • It attempts to sanitize text with wrong data type: "Warning: htmlspecialchars() expects parameter 1 to be string, array given".
  • It tries to call the following undefined functions mixed_keys and imageiolorallocate. Clearly there are more dependencies than listed in its .info.
  • It uses MD5 to secure the signature.
  • The access callback for router "commerce/w1_drupal_commerce/response" is TRUE, so presumably anyone can access it.
  • It tries to create files writeable by the web-server outside the file upload area and provides no .htaccess for protection. (This will obviously not work on any securely configured production site.)

PS: Personally, I believe that this particular developer would benefit from further guidance from the experienced git administrators that serve the community in the Project Application Review queue, rather than having to figure out how to fix the project alone, but I've complied with the request to set its status to "Fixed".

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

apaderno’s picture

Issue tags: -commerce paymentpayment method