Closed (fixed)
Project:
Backup and Migrate
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Nov 2015 at 12:02 UTC
Updated:
6 Nov 2019 at 14:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sylvainm commentedPatch attached
Comment #3
sylvainm commentedComment #4
rocketeerbkw commentedPatch applies cleanly to 7.x-3.x-dev. This is PHP4 code!
Comment #5
joelstein commentedHere's an updated patch which catches another constructor.
Comment #6
rocketeerbkw commentedComment #7
sylvainm commentedThx for catching another one.
Comment #8
ckngTested #5 working as expected.
Comment #9
frank hh-germany commented#5
Thanks for the Patch.
Works fine...
Comment #10
anybodyI can confirm RTBC. This should be a hot candidate for a new stable release. PHP7 is quite common. :)
Comment #11
heddn+1 on RTBC
Comment #12
heddnBTW, I ran this through php7cc and the only places where this deprecated format is used are fixed in the patch above.
Comment #13
bogdog400 commentedThis is a good excuse for a new stable release. It will make updating easier for everyone. 7.0 is a pretty nice version of PHP and we want to encourage it.
Comment #14
anybody+1 for #13 :)
Comment #15
nerdoc commented#13++ ;-)
Using auto backups under cron/PHP7 causes cron to vomit this deprecation warning message into my mailbox 12x each day :-( So it's not just on the screen - please merge the fix into stable!
Comment #16
nagy.balint commented+1 RTBC
Comment #17
anybody+1 for a new release. PHP7 is important :)
Comment #18
bogdog400 commentedThanks to the committers for getting these fixes in to version 7.10.
--- Oh wait. They rolled the fixes in CTools. My mistake. But please fix them here too. Thanks.
Comment #19
culfin commented+1 on RTBC ... is there anything you're waiting for?
Comment #20
nagy.balint commentedI start to think that the 7.x branch is not maintained anymore :(
Comment #21
garphyWell... maybe this issue it's a hidden request for co-maintainership ? :)
Comment #22
kevin morse commentedJust moved a bunch of my sites over to PHP7 and confirmed the patch in #5 fixes both the warnings I am seeing.
Would be great to see this released.
Comment #23
alan d. commentedNice to have this in dev irrespective if there are going to be no more D7 releases
Saves having to track mods / patches :)
Comment #24
jaypanI confirm #5 fixes the issue.
Comment #25
3dnathaniel commentedconfirm #5 fixes issue for me as well
Comment #26
anybodyThere seems to be no active maintainer?
I tried to contact, but no reply yet.
Comment #27
xtaz#5 works for me too.
Thanks.
+1 for a new release
Comment #28
wylbur commentedThe patch in #5 also worked for me when applied to the latest dev version of the module.
Comment #29
anybodyStill no reply from the maintainer... how shell we proceed?
Comment #30
nagy.balint commentedI guess we will have no choice than to use https://www.drupal.org/node/251466
Comment #32
ronan commentedPatch applied. Thanks
Comment #33
nagy.balint commentedThank you!
Comment #34
xtazThanks
Comment #35
anybodyThank you very much! That's great!
Would you be so nice to create a new D7 stable release containing this patch?
Comment #36
wizonesolutionsComment #37
howdytom commentedYeah. Patch #5 works for me, too
Thank you joelstein!
Comment #39
shahidbscs commentedyeah #5 worked
Comment #40
alh commented+1 for a new release. Just upgraded to php 7 and warnings popping up on all sites. Am applying the patch now.
Comment #41
3cwebdev commentedPatch in #5 works. Have applied to many sites that I've upgraded to PHP7.0x - hopefully this patch gets applied to the module.
Comment #42
Anonymous (not verified) commentedConfirmed that patch in #5 works like a dream. I had the same issue on all servers using PHP 7.
Thanks a million, joelstein!
Comment #43
nancydruI am using the latest Dev version (backup_migrate 7.x-3.1+11-dev 2016/12/31) and this patch does not seem to be there.
Comment #44
wOOge commentedPatch from #5 works for me as well.
Comment #45
selinav commented#5 works for me, thanks.
Comment #46
gchalker@princeton.edu commentedCan someone help me with file.inc? I am still getting this syntax error after the patch:
ParseError: syntax error, unexpected 'if' (T_IF), expecting ';' or '{' in backup_migrate_include() (line 133 of /public_html/sites/all/modules/backup_migrate/includes/files.inc)
Here is the patch:
/**
* Construct a file object given a file path, or create a temp file for writing.
*/
function __construct($params = array())
if (isset($params['filepath'])) && file_exists($params['filepath'])) {
$this->set_filepath($params['filepath']);
}
else {
$this->set_file_info($params);
$this->temporary_file();
}
}
Comment #47
jaypanThis:
Should be this:
Comment #48
damienmckennaPlease just update to 7.x-3.6 and open a new issue if you're still running into problems. Thank you.
Comment #49
gchalker@princeton.edu commentedThanks @DamienMcKenna. Updating to Backup and Migrate 7.x-3.6 alleviated all my issues. Good advice. Thank you.
Comment #50
damienmckenna@geogeektress: that's awesome, thanks for letting me know.
Comment #51
vincent wasswa commentedthanks, #5 worked.