The key on permissions quick links on the module page is upside down

Working on this as the Drupal Belgium sprint

Working on this as the Drupal Belgium sprint

Working on this as the Drupal Belgium sprint

This is not a major issue because it does not have significant repercussions and do not render the whole system unusable.

Can you give some usability references/results about key orientations to support this usability issue.

I'm tempted to put this minor but I'll change this to normal. Please feel free to change to minor if you agree with the priority.

Together with YasminKlockaerts I worked on this issue. First we tried to solve this on a css level.
However, because the key.svg file is only used here we choose to alter the svg file itself.

Here's a screenshot of patched version.

I can confirm that applying the patch indeed does what #7 shows. Therefore this patch is RTBC, IMO.

We have one other key.svg in core, do we also want to change that one as well? I would be good if they were consistent apart from the colour.

diff --git a/core/misc/icons/787878/key.svg b/core/misc/icons/787878/key.svg
old mode 100644
new mode 100755

There is no need to change permissions.

Also, I think we should keep it consistent as @LewisNyman says in #13.

Fixed the file permissions. Also, changed the icon at core/themes/stable/images/core/icons/787878/ to keep it consistent as @LewisNyman suggested in #13. Thanks.

Patch applies to 8.1.x as well on simplytest. Not sure how to verify the other icon.

Verified the patch in #15, observations are as below
1.On applying patch on drupal 8.0.x, key icon is displayed properly
2.Patch in #15 applies successfully to drupal 8.1.x also and the key icon is corrected on modules page
Attached snapshot for reference.

So is it currently the right way around for rtl websites? And are we breaking that here? Imo what is weird is having the key on the diagonal. Setting to needs review because I think we some rtl screenshots - and probably some work to fix rtl.

I agree with LewisNyman and alexpott.

So if we are changing the direction of the key for this issue it should be done in for other occurrences as well to make it consistent.

I believe if this would have been a simple vertical key then it would have made sense for ltr and rtl websites. For rtl it looks a little off.

I am still leaving this for community to review but patch in #15 does what's expected.

Screenshots before applying patch:
ltr : https://www.drupal.org/files/issues/ltr_before_patch.png
rtl : https://www.drupal.org/files/issues/rtl_before_patch.png

Screenshots after applying patch:
ltr : https://www.drupal.org/files/issues/ltr_after_patch_%2315.png
rtl : https://www.drupal.org/files/issues/rtl_after_patch_%2315.png

I have added images with vertical permission icon for both ltr and rtl languages from my local machine.

Should we move in this direction or rotate the icon for rtl languages using css from patch #15?

Setting to Needs work as apparently it requires some changes (after first having determined which ones.)

Flipping or rotating the key actually changes quite a lot.

The direction of the icon to me gives me the following impressions:
- the current version is in a position as if it would be held by the user. Giving the impression, that the (admin) user is in control.
- the reversed diagonal key would instead be held by someone else and target the user.
- vertical key seems inactive, not controlled by anyone (and is smaller in size.)

You can compare the key-icon to the wrench for "configuration", you see they are both "held" by the user. This also applies to the brush for "appearance". Changing the direction of the icon would break this metaphor that user is in control, so I would argue this actually works as designed.

curently i am working on it ......

Tested drupal_core-replaced_with_rotated_secure_key_icon-2599390-15.patch from #15 on local 8.6.x-dev and it worked fine. Please find the attached screenshot ....

I'm removing the Novice tag because I think that there isn't a clear action here based on @simohell's review.

I also updated the version to 8.9.x-dev.

Is there any key position fix for drupal 9.1?
Same issue is there as well

Verified and tested patch#15 on 9.5.x-dev. Patch applied successfully.
However, fix is not working. We need re-roll for 9.5.x-dev

After patch:

Tagging for bugsmash.

Honestly, I still think changing the direction of the key is a bad idea.

This is not a bug and I personally would regard a reversed direction more of a bug. It would in my opinion detach the icon from the style used elsewhere in the user interface - and make the action slightly less readable as the visual weight of the icon-text combination would move away from the center visually distancing the icon and text from each other. A reversed key-icon would also make it less accessible and less usable as the shape would be more difficult to distinguish from the configuration wrench icon.

It should be noted also, that there is an issue with a suggestion to away from this view for module administration moving the configuration link as a part of a dropbutton #2035079: [PP-1] Figure out what to do with the install/uninstall modules page

This is quite the issue. FWIW I searched for other key icons and not one other example had the same orientation Drupal uses. See https://www.google.com/search?channel=fs&q=key+icon

To approach it from a different angle (pun intended), perhaps we can just not use a key icon at all. This shield icon with a tick inside it is a better representation of permissions to me. https://thenounproject.com/icon/shield-2084849/

Or even the Locked with Key Emoji 🔐is another approach that is unambiguous regarding orientation.

Now that I see it I can't unsee it!

I disagree that it is about who is holding it. Is there any discussion when it was added for these icons that this was the intent?

Both the paintbrush and wrench have the heavier / larger bits up and to the left. Swapping the key makes it more consistent with those two.

If switching the icon entirely makes it easier to replace this then that might work.