Problem/Motivation

The key is the wrong way around.

Proposed resolution

Rotate it.

Remaining tasks

  • Patch that rotates it
  • Diligently observe the fact that its now the right way (review)

User interface changes

  • Changes the orientation of the key

API changes

Data model changes

CommentFileSizeAuthor
#43 after patch15.png44.15 KBsonam.chaturvedi
#37 Screen Shot 2020-07-22 at 7.01.51 PM.png383.33 KBtanubansal
#34 key-rotation.jpeg32.62 KBRithesh BK
#22 vertical_permission_ltr.png47.84 KBzuhair_ak
#22 vertical_permission_rtl.png44.43 KBzuhair_ak
#21 ltr_after_patch_#15.png17.06 KBprashantgoel
#21 rtl_after_patch_#15.png20.62 KBprashantgoel
#21 ltr_before_patch.png28.95 KBprashantgoel
#21 rtl_before_patch.png21.89 KBprashantgoel
#18 After_Patch_drupal_8.1.x.JPG126.4 KBTruptti
#18 After_pacth_drupal_8.0.x.JPG128.82 KBTruptti
#18 Patch_applied_on_drupal8.1.x.JPG31.37 KBTruptti
#18 Patch_applied_drupal_8.0.x.JPG33.63 KBTruptti
#16 key-rotation.jpeg32.62 KByoroy
#15 drupal_core-replaced_with_rotated_secure_key_icon-2599390-15.patch2.55 KBsubharanjan
#7 Screen Shot 2015-10-24 at 15.58.15.png263.96 KBiMiksu
#6 create_the_display-2596367-7.patch1.26 KBppind
Screenshot 2015-10-22 15.49.13.png202.4 KBBojhan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bojhan created an issue. See original summary.

YasminKlockaerts’s picture

YasminKlockaerts CreditAttribution: YasminKlockaerts commented
Assigned: Unassigned » YasminKlockaerts
Issue tags: +DUGBE2410

Working on this as the Drupal Belgium sprint

YasminKlockaerts’s picture

YasminKlockaerts CreditAttribution: YasminKlockaerts commented

Working on this as the Drupal Belgium sprint

YasminKlockaerts’s picture

YasminKlockaerts CreditAttribution: YasminKlockaerts commented

Working on this as the Drupal Belgium sprint

iMiksu’s picture

iMiksu
Location Finland
CreditAttribution: iMiksu as a volunteer commented
Priority: Major » Normal

This is not a major issue because it does not have significant repercussions and do not render the whole system unusable.

Can you give some usability references/results about key orientations to support this usability issue.

I'm tempted to put this minor but I'll change this to normal. Please feel free to change to minor if you agree with the priority.

ppind’s picture

ppind CreditAttribution: ppind commented
Status: Active » Needs review
FileSize
create_the_display-2596367-7.patch1.26 KB

Together with YasminKlockaerts I worked on this issue. First we tried to solve this on a css level.
However, because the key.svg file is only used here we choose to alter the svg file itself.

iMiksu’s picture

iMiksu
Location Finland
CreditAttribution: iMiksu as a volunteer commented
Issue summary: View changes
FileSize
Screen Shot 2015-10-24 at 15.58.15.png263.96 KB

Here's a screenshot of patched version.

Screenshot of the patched version

iMiksu’s picture

iMiksu
Location Finland
CreditAttribution: iMiksu as a volunteer commented
Issue summary: View changes
iMiksu’s picture

iMiksu
Location Finland
CreditAttribution: iMiksu as a volunteer commented
Issue summary: View changes
iMiksu’s picture

iMiksu
Location Finland
CreditAttribution: iMiksu as a volunteer commented
Issue summary: View changes
kekkis’s picture

kekkis
he/him
Primary language Finnish
Location Pirkkala
CreditAttribution: kekkis as a volunteer commented
Assigned: YasminKlockaerts » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I can confirm that applying the patch indeed does what #7 shows. Therefore this patch is RTBC, IMO.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented

Awesome :)

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Status: Reviewed & tested by the community » Needs review

We have one other key.svg in core, do we also want to change that one as well? I would be good if they were consistent apart from the colour.

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
Status: Needs review » Needs work 
diff --git a/core/misc/icons/787878/key.svg b/core/misc/icons/787878/key.svg
old mode 100644
new mode 100755

There is no need to change permissions.

Also, I think we should keep it consistent as @LewisNyman says in #13.

subharanjan’s picture

subharanjan CreditAttribution: subharanjan commented
Assigned: Unassigned » subharanjan
Status: Needs work » Needs review
FileSize
drupal_core-replaced_with_rotated_secure_key_icon-2599390-15.patch2.55 KB

Fixed the file permissions. Also, changed the icon at core/themes/stable/images/core/icons/787878/ to keep it consistent as @LewisNyman suggested in #13. Thanks.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Version: 8.0.x-dev » 8.1.x-dev
FileSize
key-rotation.jpeg32.62 KB

Patch applies to 8.1.x as well on simplytest. Not sure how to verify the other icon.

subharanjan’s picture

subharanjan CreditAttribution: subharanjan commented
Assigned: subharanjan » Unassigned
Truptti’s picture

Truptti CreditAttribution: Truptti at Axelerant commented
FileSize
Patch_applied_drupal_8.0.x.JPG33.63 KB
Patch_applied_on_drupal8.1.x.JPG31.37 KB
After_pacth_drupal_8.0.x.JPG128.82 KB
After_Patch_drupal_8.1.x.JPG126.4 KB

Verified the patch in #15, observations are as below
1.On applying patch on drupal 8.0.x, key icon is displayed properly
2.Patch in #15 applies successfully to drupal 8.1.x also and the key icon is corrected on modules page
Attached snapshot for reference.

Truptti’s picture

Truptti CreditAttribution: Truptti at Axelerant commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs review

So is it currently the right way around for rtl websites? And are we breaking that here? Imo what is weird is having the key on the diagonal. Setting to needs review because I think we some rtl screenshots - and probably some work to fix rtl.

prashantgoel’s picture

prashantgoel CreditAttribution: prashantgoel as a volunteer commented
Issue summary: View changes
FileSize
rtl_before_patch.png21.89 KB
ltr_before_patch.png28.95 KB
rtl_after_patch_#15.png20.62 KB
ltr_after_patch_#15.png17.06 KB

I agree with LewisNyman and alexpott.

So if we are changing the direction of the key for this issue it should be done in for other occurrences as well to make it consistent.

I believe if this would have been a simple vertical key then it would have made sense for ltr and rtl websites. For rtl it looks a little off.

I am still leaving this for community to review but patch in #15 does what's expected.

Screenshots before applying patch:
ltr : https://www.drupal.org/files/issues/ltr_before_patch.png
rtl : https://www.drupal.org/files/issues/rtl_before_patch.png

Screenshots after applying patch:
ltr : https://www.drupal.org/files/issues/ltr_after_patch_%2315.png
rtl : https://www.drupal.org/files/issues/rtl_after_patch_%2315.png

zuhair_ak’s picture

zuhair_ak
He/Him
Primary language Malayalam
Location Dubai
CreditAttribution: zuhair_ak at Zyxware Technologies commented
FileSize
vertical_permission_rtl.png44.43 KB
vertical_permission_ltr.png47.84 KB

I have added images with vertical permission icon for both ltr and rtl languages from my local machine.

vertical permission icon ltr

vertical permission rtl

Should we move in this direction or rotate the icon for rtl languages using css from patch #15?

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Issue tags: +Dublin2016

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

ZeiP’s picture

ZeiP CreditAttribution: ZeiP at Citrus Solutions Oy commented
Status: Needs review » Needs work

Setting to Needs work as apparently it requires some changes (after first having determined which ones.)

Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented

Wait, what. Why did we move from diagonal to vertical? Yes its easier, but diagonal looks much better!

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

simohell’s picture

simohell CreditAttribution: simohell commented
Issue tags: +Vienna2017

Flipping or rotating the key actually changes quite a lot.

The direction of the icon to me gives me the following impressions:
- the current version is in a position as if it would be held by the user. Giving the impression, that the (admin) user is in control.
- the reversed diagonal key would instead be held by someone else and target the user.
- vertical key seems inactive, not controlled by anyone (and is smaller in size.)

You can compare the key-icon to the wrench for "configuration", you see they are both "held" by the user. This also applies to the brush for "appearance". Changing the direction of the icon would break this metaphor that user is in control, so I would argue this actually works as designed.

Ivan Berezhnov’s picture

Ivan Berezhnov CreditAttribution: Ivan Berezhnov as a volunteer and at Drupal Ukraine Community for Levi9 commented
Issue tags: +CSKyiv18

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Rithesh BK’s picture

Rithesh BK CreditAttribution: Rithesh BK as a volunteer and at Valuebound for Valuebound commented
Assigned: Unassigned » Rithesh BK

curently i am working on it ......

Rithesh BK’s picture

Rithesh BK CreditAttribution: Rithesh BK as a volunteer and at Valuebound for Valuebound commented
Assigned: Rithesh BK » Unassigned
Status: Needs work » Needs review
FileSize
key-rotation.jpeg32.62 KB

Tested drupal_core-replaced_with_rotated_secure_key_icon-2599390-15.patch from #15 on local 8.6.x-dev and it worked fine. Please find the attached screenshot ....

mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe at Kosada commented
Version: 8.6.x-dev » 8.9.x-dev
Issue summary: View changes
Issue tags: -Novice +Needs usability review

I'm removing the Novice tag because I think that there isn't a clear action here based on @simohell's review.

I also updated the version to 8.9.x-dev.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

tanubansal’s picture

tanubansal CreditAttribution: tanubansal at Salsa Digital commented
FileSize
Screen Shot 2020-07-22 at 7.01.51 PM.png383.33 KB

Is there any key position fix for drupal 9.1?
Same issue is there as well

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Priority: Normal » Minor

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sonam.chaturvedi’s picture

sonam.chaturvedi CreditAttribution: sonam.chaturvedi at Salsa Digital commented
FileSize
after patch15.png44.15 KB

Verified and tested patch#15 on 9.5.x-dev. Patch applied successfully.
However, fix is not working. We need re-roll for 9.5.x-dev

After patch:
after patch

sonam.chaturvedi’s picture

sonam.chaturvedi CreditAttribution: sonam.chaturvedi at Salsa Digital for Drupal India Association commented
Status: Needs review » Needs work

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue tags: +Bug Smash Initiative

Tagging for bugsmash.

simohell’s picture

simohell CreditAttribution: simohell commented

Honestly, I still think changing the direction of the key is a bad idea.

This is not a bug and I personally would regard a reversed direction more of a bug. It would in my opinion detach the icon from the style used elsewhere in the user interface - and make the action slightly less readable as the visual weight of the icon-text combination would move away from the center visually distancing the icon and text from each other. A reversed key-icon would also make it less accessible and less usable as the shape would be more difficult to distinguish from the configuration wrench icon.

It should be noted also, that there is an issue with a suggestion to away from this view for module administration moving the configuration link as a part of a dropbutton #2035079: [PP-3] Figure out what to do with the install/uninstall modules page

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.