[D7] Membership Entity Expiration Notice

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxkissjozsef2594193git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi kiss.jozsef kindly add hook_menu with this format. https://www.drupal.org/node/161085

Thanks,
Rahul.

Hi @kiss.jozsef thanks for pointing out my mistake, yes i meant to add hook_help but by mistakenly i have written hook_menu. :)

@kiss.jozsef for implementing hook_help.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder.

Review of the 7.x-1.x branch (commit 86eb25e):

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: ...-7-pareview/pareview_temp/membership_entity_expiration_notice.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
72 | ERROR | [x] Array closing indentation error, expected 6 spaces but
| | found 10
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

README.txt

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. Please fix the Indentation Error in Line 72 of membership_entity_expiration_notice.module as described by the Automated Tests above

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi kiss.jozsef

Well I saw your code and its good, except a thing:
You are storing some variable in a validation callback, which is not a good way, save your data in form submit not in validation callback.
Add a submit function in that form alter of yours and then save your variable there instead of doing all that during validation.

Module looks good and working for me. I think we don't have any blocker points. So i am marking as RTBC.

Only one suggestion :
Delete the variable "membership_entity_type_settings"

function hook_uninstall() {
  variable_del('membership_entity_type_settings');
}

Thanks for your contribution, kiss.jozsef! You are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process, especially my slowness in approving following review. We know it's broken and are trying to fix it.