[D7] Sortable Lists

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2558035

Project 2: https://www.drupal.org/node/2535442

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxkporras072558027git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Kevin,

Follow the following template for your README.txt file.

Also coder showing the following warnings

1. (*) Line 31: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
   function updateValue() {
2. (*) slieverity: normalreview: style_camel_caseLine 36: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
   function getId(text) {
3. (*) severity: normalreview: style_camel_caseLine 47: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
   function getItems(container) {

For example,

In your README file you have described each heading as

*Introduction

If you need a form api element that provides any number of sortable lists and
you can move elements from one to another and order them; you could use the
element type that this module provides.

Here the format is wrong.

but it should be like following :

INTRODUCTION
--------------------
The Administration Menu module displays the entire administrative menu tree
(and most local tasks) in a drop-down menu, providing administrators one- or
two-click access to most pages. Other modules may also add menu links to the
menu using hook_admin_menu_output_alter().

You will have to take care of the line spacing and formatting.

Follow README TEMPLATE.

Hi kporras07,

I have found $form['input'] at line 171 in sortable_lists.module. Use $form['values'] instead.

Thanks.

I think you have to add instructions in the README.md, Project page and hook_requirements() to indicate to the users how to name the external library, maybe something like that: Please add this name to your library folder : jquery-drop-down-widget.

The library naming sounds like a good improvement, but is surely not an application blocker. Anything else that you found or should this be RTBC instead?

thanks for the correction @klausi, and only one more thing, when I test the form element the first time I only see the columns but I can't drag the column items:

After that I reviewed the navigator console and see this error:

I suppose is something with the drupal jquery. @kporras07 your module needs a specific jquery version?

Hi @kporras07 thanks for the correction, now works perfectly, nice job!!!!

Setting RTBC

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.