This module provides +1 voting style functionality.
Based on votingapi, this module adds a field type that you could add to any entity/bundle for having +1 voting functionality.
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/kporras07/2535432.git voting_plus_one && cd voting_plus_one
This is a simple +1 voting module; this is the only functionality that this module provides.:
Rate module provides various vote widgets; so much overhead for a simple requirement.
I don't provide vote down functionality; because it's not necessary. If I'd need it; I'd use Vote Up/Down
My module works for any entity and since it's a field type; it could be integrated wherever Field API could be used.
I've been working with Drupal since about 2 years ago; I've contributed with various issues in different projects; between them: User Badges (I started the 4.x branch), Open Atrium Core and others.
Comments
Comment #1
kporras07 commentedComment #2
kporras07 commentedComment #3
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
babusaheb.vikas commented1) You should provide the hook_help to allow site builders to find information about your module using Drupal UI.
2) It would be better if your *.info file looks like
name = Voting Plus One
description = Provides a plus one style voting system.
core = 7.x
dependencies[] = votingapi
dependencies[] = entity
3) Follow the guidelines for in-project documentation
and/or the
README template
4) One warning with pareview.sh
http://pareview.sh/pareview/httpgitdrupalorgsandboxkporras072535432git
please fix it.
Comment #5
Anonymous (not verified) commentedHi,
thank you for your module!
I'll try to give my small contribution.
Manual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Sorry, i am unable to say whether the fact of "doing only one thing" is an argumentation strong enough to prevent it being considered a duplicate.
As you said we can easly achieve the same result with many modules, and there is the risk of having to change or to install a new module to the first minimum need to change the way of vote.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: as noticed by babusaheb.vikas
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
In my humble opinion, Yes: Meets the security requirements.
Coding style & Drupal API usage
I did not find big mistakes, but for this too you will need to wait for the review of someone more experienced.
Other issues
* As noticed by babusaheb.vikas you should provide the hook_help().
* I tried your module by adding a field to a content type and to users.
It works, but it prints the result without the space : ie “1Vote”.
* Perhaps it would be useful to also have the option to withdraw a vote; maybe someone changes his mind, or clicked by mistake.
Greetings
This was my little contribution. I'm following and studying the reviews, and the reviews of the reviews, to deepen my knowledge of Drupal and to be able to provide better contributions.
Sorry if I seem rude, perhaps caused by my faltering English.
I wish you a good job! :)
2015-07-19 Update
Hi!
Some new things:
1) a) If I try to add a second voting field to the same content type, the administration panel does not returns errors, but the second field dont appears in the content (it displays only the first). Even if I empty the cache.
Now, if I add a new custom text field on the same content type (Article in my example), and then I insert a value in this field... voila the second voting field!
Perhaps I done something wrong? But it happened in both my test of yesterday and today.
1) b) However now I have two buttons. But if I click a button, both fields increase by one (with Javascript disabled you can immediately notice it, otherwise you have to refresh the page)
2) If I delete a field, and then I create a new one, which has another machine name, the new one contains the results of the old field.
I apologize in advance, today and in the next few days i'm out of town and I can not do more extensive testing.
Comment #6
ashish.verma85 commentedHi,
Thanks for the effort,
few things are missing:
1. It is recommended to always implement hook_install(). Here you can find an example.
2. You should provide the hook_help to allow site builders to find information about your module using Drupal UI.
3. package namee, php version and configuration links are missing from your *.info file.
Thanks
Comment #7
Torvald commentedHi kporras07,
I have reviewed your module.
Good work!
Please pay attention to my comments:
Thanks!
Comment #8
PA robot commentedProject 1: https://www.drupal.org/node/2558035
Project 2: https://www.drupal.org/node/2535442
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #9
avpaderno