[D7] Youtube channel subscribe

It seems like your GIT repository is empty. Please upload your code in to the git repository, then only can proceed with further review.

Thanks,
ARUN AK

Hi Ajay Gadhavana,
Your project page is missing the most crucial part of any project, the git clone link. On visiting the Version Control Tab of your module, I found it missing there too. Please follow proper instructions for the same.
However, I downloaded the zip file of your project, and found quite errors.
1. Remove the README.txt~ from your project.
2. Remove the version tag from the *.info file.
3. Comments missing in the *.module and *.inc file.
4. White spaces missing here and there. Please perform Pareview Test to know the details.
5. In the *.inc file, please use get_t() with the description tag.
6. Use isset() instead of array_key_exists()/ empty() in *.module file.

Hi Ajay,

Kindly add the git clone link as well as pareview.sh link too.

@Ajay,

You have to add the links in your project description section.
Or you can read the instructions on below links:
https://www.drupal.org/node/632262

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Sandbox git link is broken.

http://git.drupal.org/sandbox/ajay.gadhavana/2550017.git

We also need a link to your sandbox project.

Hi,

Functionality looks very good. Please find my comments on module review.

Automated Review

No issues found in automation review

http://pareview.sh/pareview/httpgitdrupalorgsandboxajaygadhavana2550017git

Manual Review

Individual user account

[Yes: Follows ] the guidelines for individual user accounts.

No duplication

No duplication found.

Master Branch

[Yes: Follows ] the guidelines for master branch.

Licensing

[Yes: Follows / No: Does not follow] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

1. (*) Major finding, needs work

1. Incorrect access argument used in youtube_channel_subscribe_menu() 'access arguments' => array('Administration Menu'),

2. (+) Release blocker
3. Just a recommendation

1. Naming conventation for inc file name should be youtube_channel_subscribe.admin.inc 'file' => 'youtube_channel_subscribe_admin.inc',

This review uses the Project Application Review Template.

Thanks,
Ashish

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. README.txt it is unclear what you ened to fill in and where, can you improve this in the text.
2. youtube_channel_subscribe.module => [29] rewrite this inline if to a full "if (){ }" for readability and maintenance.
3. Remove te License file from the repo, drupal allready adds the GPL 2 License for you.
4. README.txt "Error - Error at the place of button; Solution : Please confirm that you placed right channel name or channel id in configuration page" This is not a proper error nor is it an issue. What is an issue here is a non descriptive error message. you should rewrte the message so its clear what is wrong, and what the enduser should do.
5. README.txt "MORE INFORMATION; ----------------; - There are no more information.;" if a block is empty, remove it.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thanks for your contribution, Ajay!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

@Ajay: Just create a new branch, you don't have to go through the process again.