Follow-up to #2078803: Change contextual links background color to match the styleguide.

Problem/Motivation

See discussion in: #2195695: Admin UIs on the front-end are difficult to theme

Contextual links are an administrative UI component that appears on the frontend of sites. It's important that they are consistent with the Seven style guide and that other admin themes can control the look and feel.

Proposed resolution

Our CSS standards define module CSS as: “the minimal styles needed to get the module's functionality working.”
Theme CSS is defined as: “extra styles to make the module's functionality aesthetically pleasing. ”
Move the theme styling into the Seven theme
Add a library alter hook to load the admin theme CSS. Example: #2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs

Remaining tasks

Write the patch.
Test.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#11 move_theme_contextual-2539986-11.patch5.66 KBisholgueras
#8 move_theme_contextual-2539986-8.patch5.73 KBisholgueras
#3 Screenshot 2015-09-11 12.25.07.jpg532.74 KBlewisnyman
#2 Screenshot 2015-09-11 12.15.39.jpg577.09 KBlewisnyman
#2 move_theme_contextual-2539986-2.patch4.69 KBlewisnyman

Comments

lewisnyman’s picture

lewisnyman
he/him
commented
Parent issue: #2078803: Change contextual links background color to match the styleguide. » #2489460: [Meta] Move module.theme.css files to Classy or Seven
Related issues: +#2078803: Change contextual links background color to match the styleguide.
lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new move_theme_contextual-2539986-2.patch4.69 KB
new Screenshot 2015-09-11 12.15.39.jpg577.09 KB

Here's a patch and a screenshot

lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
StatusFileSize
new Screenshot 2015-09-11 12.25.07.jpg532.74 KB

If you set your admin theme to Stark, this is what it looks like. Very basic but functional.

irina.rozite’s picture

irina.rozite commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Screenshots look good, but patch needs reroll

LewisNyman queued 2: move_theme_contextual-2539986-2.patch for re-testing.

The last submitted patch, 2: move_theme_contextual-2539986-2.patch, failed testing.

isholgueras’s picture

isholgueras commented
Assigned: Unassigned » isholgueras

Working on it

isholgueras’s picture

isholgueras commented
Assigned: isholgueras » Unassigned
Status: Needs work » Needs review
StatusFileSize
new move_theme_contextual-2539986-8.patch5.73 KB

Done

irina.rozite’s picture

irina.rozite commented
Status: Needs review » Needs work
Issue tags: -Needs reroll

CSS files have been specified in the wrong place. They must be specified in seven.info.yml via the "contextual_links_stylesheets" like in #2 patch and not in the seven.libraries.yml

isholgueras’s picture

isholgueras commented
Assigned: Unassigned » isholgueras
Status: Needs work » Needs review

I saw in Bartik that these files are added in bartik.libraries.yml and I supose that these changes needs to be in seven.libraries.yml and not in seven.info.yml.

I'll add these files to seven.info.yml now.

isholgueras’s picture

isholgueras commented
Assigned: isholgueras » Unassigned
StatusFileSize
new move_theme_contextual-2539986-11.patch5.66 KB

Done

irina.rozite’s picture

irina.rozite commented
Status: Needs review » Reviewed & tested by the community

Latest patch applies and resolves the issue. Functionality is the same as supposed to be in #2 patch so the result screenshots are the same as in @LewisNyman comments.

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Reviewed & tested by the community » Postponed

Thanks, postponed on #2566775: [Voltron patch] Move all remaining *.admin.theme.css to Seven

manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented

#2566775: [Voltron patch] Move all remaining *.admin.theme.css to Seven is active.

manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Status: Postponed » Needs work

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Postponed (maintainer needs more info)

Is this something we still need to do now we have libraries_extends and libraries_override?

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there hasn't been movement for so long and seven is removed in D10 closing out.