Problem/Motivation

To much specificity on the list on default css for breadcrumbs and list defaults.

Proposed resolution

- Remove additional definitions on breadcrumbs
- as well cleanup the rtl and ltr attributes on ul and ol
- and pay attention to browser defaults

Remaining tasks

Needs review

CommentFileSizeAuthor
#15 css_cleanup_and_killing-2512870-15.patch1.36 KBempesan
#11 css_cleanup_and_killing-2512870-11.patch1.24 KBtassilogroeper
#9 rtl updated margin.png214.16 KBtassilogroeper
#9 ltr updated margin.png231.32 KBtassilogroeper
#9 current list margin with chrome styles overriding.png238.5 KBtassilogroeper
#5 Bildschirmfoto 2015-09-25 um 10.38.02.png84.38 KBtassilogroeper
#5 Bildschirmfoto 2015-09-25 um 10.39.55.png78.36 KBtassilogroeper
#1 2512870-1.patch1.13 KBmunzirtaha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

munzirtaha’s picture

munzirtaha CreditAttribution: munzirtaha as a volunteer commented
Assigned: munzirtaha » Unassigned
FileSize
2512870-1.patch1.13 KB

Attached is the patch

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Issue tags: +frontend

Ok thanks. I will review this when I get a chance. It looks like we are modifying system CSS here, so that would affect every theme?

tassilogroeper’s picture

tassilogroeper CreditAttribution: tassilogroeper commented

working in BarcelonaCon on this issue. Needs re-roll. https://www.drupal.org/contributor-tasks/reroll

tassilogroeper’s picture

tassilogroeper CreditAttribution: tassilogroeper commented
Issue tags: +Needs reroll
tassilogroeper’s picture

tassilogroeper CreditAttribution: tassilogroeper commented
FileSize
Bildschirmfoto 2015-09-25 um 10.39.55.png78.36 KB
Bildschirmfoto 2015-09-25 um 10.38.02.png84.38 KB

checking the rtl vs ltr in the breadcrumbs. see picture, nothing wrong with removing the additional override.

fatfish’s picture

fatfish CreditAttribution: fatfish at FatFish commented

Im workin on it on DrupalCon Barcelona2015

tiefield’s picture

tiefield CreditAttribution: tiefield as a volunteer commented

I am trying to make an issue summery based on the issue template. https://www.drupal.org/contributor-tasks/write-issue-summary

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented

@fatfish Hi, someone already started to work on that issue (see comment #3)
You can come and join us in room 115 on the "stuff" table (see the map at the entrance)

tassilogroeper’s picture

tassilogroeper CreditAttribution: tassilogroeper commented
FileSize
current list margin with chrome styles overriding.png238.5 KB
ltr updated margin.png231.32 KB
rtl updated margin.png214.16 KB

since we are talking about the basic settings of lists, there are a couple things to consider:

- as shown in the first screenshot (see "current list margin with chrome styles overriding.png") browsers will apply their own padding - if not set. so set a padding 0 to ul.
- Furthermore we should align ul and ol insets commonly to 1.5em.
- lastly only apply the margin on the inset, leaving the opposite side (without the numbers or dots) set to 0 (see the "... updated margin.png")

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Issue tags: +Barcelona2015

I'm mentoring on that issue at DrupalCon Barcelona :)

tassilogroeper’s picture

tassilogroeper CreditAttribution: tassilogroeper commented
FileSize
css_cleanup_and_killing-2512870-11.patch1.24 KB
tassilogroeper’s picture

tassilogroeper CreditAttribution: tassilogroeper commented
Issue tags: -Needs reroll

re-roll is done in the patch

tiefield’s picture

tiefield CreditAttribution: tiefield as a volunteer commented
Issue summary: View changes
JulienD’s picture

JulienD CreditAttribution: JulienD as a volunteer commented
Issue tags: +Needs steps to reproduce
empesan’s picture

empesan CreditAttribution: empesan commented
FileSize
css_cleanup_and_killing-2512870-15.patch1.36 KB

I've reproduced the problem but a new re-roll was needed. There's a patch based on tassilogroeper solution (#11).

dorficus’s picture

dorficus CreditAttribution: dorficus as a volunteer commented

Can you provide instructions to reproduce with the new patch? Everything looks good, but before I RTBC I'd like to check to be certain.

Saphyel’s picture

Saphyel CreditAttribution: Saphyel as a volunteer commented

Looks fine, very well documented.
For replicate it, with the seven theme, create a node with this body:

<ul>
<li>Lorem Ipsum</li>
<li>Lorem Ipsum</li>
</ul>
<ol>
<li>Lorem Ipsum</li>
<li>Lorem Ipsum</li>
</ol>

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue tags: -Novice

There is no obvious next step for a Novice.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime at Lil Engine commented

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Component: Seven theme » Starterkit theme

The Seven theme has been removed from Drupal 10 core. However, this patch appears to also affect the starter kit CSS, so moving to the Starterkit component.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Work needs to be updated for the starterkit theme.

Tagging for IS for remaining tasks to be relooked at.

Thanks

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.