[D7] IT Cookie Compliance

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxfilippoledda2508371git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Kudos for awesome module. Your overall code is neat and clean.
Still there are few issue found by pareview.sh script.

FILE: ...tes/all/modules/contrib/it_cookie_compliance/js/it_cookie_compliance.js
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] Additional whitespace found at start of file
11 | ERROR | [x] Expected 1 newline at end of file; 4 found
14 | ERROR | [ ] More than 2 empty lines are not allowed
14 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

For writing javascript as per D7 standard to maintain compatibility you can follow this guide:
https://www.drupal.org/node/171213

Automated Review

pareview.sh: http://pareview.sh/pareview/httpgitdrupalorgsandboxfilippoledda2508371git

Looks good except for the note about not having test cases.

coder review: looks good

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation. I found the EU Cookie Compliance module that looked like it might be similar, but it specifically states that Prevention of cookies being set on a website is not in the scope of this module

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. While it isn't a project blocker, it would be helpful to implement hook_help()

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I don't see any blockers, though adding the hook_help() would be useful.

Manual review :

1. "trim($script_to_exclude)" use drupal function "truncate_utf8" instead of trim.
2. it_cookies_compliance.js: use Drupal.behaviors instead. See https://www.drupal.org/node/756722

I'd still recommend fixing the things in #7, but they aren't blockers for this application.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.