[D7] Japan Postal Code

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2501525

Project 2: https://www.drupal.org/node/2241231

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgh6402501521git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi hgoto,

I have take pareview and manual review for your module.

There were no pareview issues, but found bugs, please review the patch, fix it and test again.

Please update git repository "gh640@git.drupal.org:sandbox/gh640/2501521.git" to "http://git.drupal.org/sandbox/gh640/2501521.git" in description, and the path `admin/config/services/japan-postal-code/%` of features tips may be `japan-postal-code/address/%`.

Bugs

1. Incorrect use db_transaction
2. Address table always empty when click "Clear and update postal code table", I think it should not execute if fail to get postal_codes_normal or postal_codes_special.

Suggestions

1. Add configure to japan_postal_code.info, so user can see the configuration link in module list page.
configure = admin/config/services/japan-postal-code

I will think about integrate your module, then let "addressfield_jp" to support another choice for address lookup with your module.

Automated Review

Fix errors in automated review

Manual Review

* Implements hook_help()
It is recommended to get the basic understanding of the module to new users.

Hi,
Automated Review
Used Coder Module - 1 normal warnings
Manual Review
Individual user account
Yes
No duplication
Yes
Master Branch
Yes
3rd party assets/code
No,Not applicable
README.txt
Yes
Issues

1. In admin/config/services/japan-postal-code There is no button to fetch Japan postal code data from Japan post office website
2. When give permissions of Japan Postal Code to authenticated user error occurs: HTTP error -1 occurred when trying to fetch http://www.post.japanpost.jp/zipcode/dl/kogaki/zip/ken_all.zip.
3. Japan postal code database table update failed.

Automated Review

Best practice issues identified by pareview.sh.

FILE: /var/www/drupal-7-pareview/pareview_temp/japan_postal_code.test
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
41 | ERROR | [x] Array closing indentation error, expected 4 spaces but
| | found 6
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

Manual Review

Individual user account

Yes: Follows.

No duplication

Yes.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

japan_postal_code.drush.inc

1. (*) The help hook is copied from another module.
   

   /**
    * Implements hook_drush_help().
    */
   function japan_postal_code_drush_help($section) {
     switch ($section) {
       case 'drush:delete-all':
         return dt("Delete all nodes, nodes of a specific content type or users.");
     }
   }
   

2. There is a typo on the documentation of japan_postal_code_drush_update(). It says "upate".
   

   /**
    * Drush callback to fetch and upate the Japan postal code.
    *
    * @see japan_postal_code_config_form_submit()
    */
   

japan_postal_code.module

1. I couldn't understand why is this: Is it needed?
   

     // Strip the unnecessary part of the address data.
     if ($address_under_city === '以下に掲載がない場合') {
       return '';
     }
   

README.txt

1. There is a typo on the "related" word. it says "releated".

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Seems that is almost ready for being published. Only one major issue found.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

@hgoto I found another small issue on this docblock

/**
 * Load all the rows of Japan postal code csv and extract necessary columns.
 *
 * @param string $filepath
 *   The file path of the csv file containing Japan postal code data.
 * @param string $type
 *   Postal code type among 2: 'normal' or 'special'.
 *
 * @return array
 *    Address data extracted from the csv.
 *
 * @see _japan_postal_code_fetch_and_load_postal_code_csv()
 */

The return description has an extra space so it isn't aligned with the other sentences above.

It looks good and ready to be published to me though.

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.