[D7] Fancyselect module

Thanks for your contribution!
a)Please fix the automated review errors http://pareview.sh/pareview/httpgitdrupalorgsandboxmishradileep2492547git
b)Some of your commits are not connected with your a/c https://www.drupal.org/node/2492547/commits Please specify your email address .See
c) Use the Readme template for readme.txt
d)Is your module working with both libraries module branches 1.x and 2.x ?
e) wrong doc block fancyselect_uninstall
f) hook_init : Please add the js/css files on specific pages where it is required.Use hook_page_build instead.
g)hook_help is nice in module.Move hook_menu from bottom of file to below the hook_help from bottom of the file.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

No errors in the Pareview.sh - http://pareview.sh/pareview/httpgitdrupalorgsandboxmishradileep2492547git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. What are the steps to configure this module ? Enable the module, created a Term of reference and use the widget Select List. I went to the content type and did not see anything different.
2. Your module said that needs to have jQuery 1.7 Higher I was using jQuery 1.10 and did not let me install the module. I think either you should fix that or add in your README.txt that it most use jQuery 1.7.
   
3. There is a typo in your module description. It said Drupalh instead of Drupal.
   
4. I think you should add this page admin/config/user-interface/fancyselect as your configuration page.
5. Coder Module:
   fancyselect.module
   
   

   Line 19: Use an indent of 2 spaces, with no tabs
                  )),

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

If you can provide me more details about your project, I probably can do a more deep review and change it to RTBC.

@darol100 Could you please re-review?

@Albert Volkman,

I will spend sometime tonight on reviewing this project.

@darol100 Hey there, just checking in :)

I think you should add this page admin/config/user-interface/fancyselect as your configuration page....

• I mean adding the configuration in your .info file, which will allow user to enable the module from admin/module.

I do not see any blockers, this project looks good to me.

Assigning it to myself for next review that might be tonight

Automated Review

Fine.

Manual Review

Review of the 7.x-1.x branch (commit 8681d04):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. I got the erros when I tried to install the module using drush. There might be something wrong that I did not investigate.
   

   Drush command terminated abnormally due to an unrecoverable error.                                                                                                                               [error]
   Error: Call to undefined function libraries_get_path() in /Applications/Mamp/htdocs/www/d7/sites/all/modules/pareview_temp/fancyselect.install, line 15
   
   na

2. fancyselect_page_build : Please sanitize the data $fancyselect_dom_selector before passing it to jquery there might be XSS here. I have tried not exploited yet, but we should sanitize the variables . so please do check_plain on this before passing it to js.
3. Please use the project page template for the project page https://www.drupal.org/node/2190239 and see the tips https://www.drupal.org/node/997024

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Not seeing any blocking issues. Assigning to pushpinderrana for a second look if he has time. Otherwise, I will promote in a few days.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. yes, few issues listed below.

Review of the 7.x-1.x branch (commit 2a04d2d):

js/fancyselect.js: line 1, col 2, Error - Use the function form of "use strict". (strict)
js/fancyselect.js: line 3, col 21, Error - Missing space before function parentheses. (space-before-function-paren)
js/fancyselect.js: line 4, col 30, Error - Missing space before function parentheses. (space-before-function-paren)
js/fancyselect.js: line 6, col 56, Error - Missing space before function parentheses. (space-before-function-paren)
js/fancyselect.js: line 6, col 58, Error - Missing space before opening brace. (space-before-blocks)
js/fancyselect.js: line 10, col 4, Error - Expected indentation of 4 characters but found 2. (indent)
js/fancyselect.js: line 11, col 4, Error - Missing semicolon. (semi)

FILE: /var/www/drupal-7-pareview/pareview_temp/js/fancyselect.js
------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
10 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/fancyselect.install
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
19 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, or question marks
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

Manual Review

Issue raised by @naveenvalecha has been addressed.

Nothing major jumped out to me as its already in RTBC so...

Thanks for your contribution, Dileep Mishra!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.