Role-based permissions to control adding new taxonomy terms with the autocomplete widget.

Drupal 7 taxonomy defines permission to edit or delete terms, but not whether a user can add terms. Furthermore, the "taxonomy autocomplete widget" always assumes users can add new terms. There is currently no way to allow some roles the ability to add a taxonomy term via the autocomplete widget and restrict other roles.

Permission screen
Validation message

https://www.drupal.org/sandbox/markfullmer/2492455

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/markfullmer/2492455.git taxonomy_autocomplete_permission
CommentFileSizeAuthor
#2 permission.png40.68 KBmark_fullmer
warning-message.png38.58 KBmark_fullmer

Comments

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Issue summary: View changes
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Issue summary: View changes
StatusFileSize
new permission.png40.68 KB
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmarkfullmer2492455git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs work » Needs review

All PAreview syntax suggestions incorporated: http://pareview.sh/pareview/httpgitdrupalorgsandboxmarkfullmer2492455git

darol100’s picture

darol100 commented
Status: Needs review » Needs work

Automated Review

Pareview.sh is not showing some errors - http://pareview.sh/pareview/httpgitdrupalorgsandboxmarkfullmer2492455git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
No: Follows the guidelines for project length and complexity.

This project is too short.

Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) You need to work on your README.txt, does not follow our guidelines for in-project documentation. Please follow this article README Template.
  2. I would recommend to add the hook_help, this can be very useful for site builders
  3. (*)This module require the taxonomy in order to work. For this reason, you should add the taxonomy as your dependecy.
  4. Line 20, in your readme you have a typo "autcomplete".
  5. Would you be interested on a single project promotion? Since this project is too short we can't grant vetted access.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I think this should be a patch to the Taxonomy module ?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Needs review

README improvements and the missing dependency to taxonomy.module are surely not application blockers (people probably know that this will only work with taxonomy enabled). Anything else that you found or should this be RTBC instead?

darol100’s picture

darol100 commented
Status: Needs review » Reviewed & tested by the community

This should be RTBC.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Thanks for your feedback darol100 and klausi!

For thoroughness' sake, I made the README better match module documentation guidelines, and added "taxonomy" as a dependency.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.