"View draft" opens published version / "Edit draft" opens correctly

We are also experiencing the same issue here. We will look further into it and try to find out why.

Hi jayhawkfan75. Are you using Panels and Display suite?

I found the bug in the nodedraft.inc file.
The workbench_moderation_nodedraft() function is returning $function($node); instead of $function($current_node);

This is the patch to fix this problem.

I am assuming we are facing the same problem here. Workflow and everything is setup nicely, however when 'saving a draft', or clicking on 'view draft' gives WSOD (White screen) on:

/node/1126/revisions/1413/view
and
/node/1126/draft

Cheers,

I think WSOD was mainly because of my setup but had to setup development module + rsyslog in order to see the underlying issue was related to: https://www.drupal.org/node/1838640

I am getting the WSOD.

This happens when you have a published node and a draft version. When you click View draft WSOD appears.

I see this error in my error logs from the core common.inc file
[] operator not supported for strings in includes/common.inc on line 2487

Seems like it is related to the class attribute in a link not being and array.

Any ideas???

UPDATE
Sorry false alarm. This was related to a custom implementation of hook_men_alter not using an array for the link class.

Thanks for a great module.

I looked at the patch in #6 and this did not work for me. Then I traced execution.

To me, it looks like we're losing track of the proper revision in workbench_moderation_router_item_page_callback. The correct node/vid is passed into this function, but when we call menu_get_item, $router_item['page_arguments'] is populated with the published version of the node... and so the correct vid is discarded.

function workbench_moderation_router_item_page_callback($node) {
  $router_item = menu_get_item('node/' . $node->nid);
  if ($router_item['include_file']) {
    require_once DRUPAL_ROOT . '/' . $router_item['include_file'];
  }

  // Call whatever function is assigned to the main node path but pass the
  // current node as an argument. This approach allows for the reuse of of Panel
  // definition acting on node/%node.
  return call_user_func_array($router_item['page_callback'], $router_item['page_arguments']);
  
  // LINE ADDED: Note, using this return sorta works, but some modules, like restws take different arguments and so it's not safe.
  // and I have no idea what other calls might be happening here. 
  return call_user_func_array($router_item['page_callback'], array($node));
}

If I change our version of workbench_moderation_router_item_page_callback to this, it seems to work both with and without restws (which takes over some paths) installed.

function workbench_moderation_router_item_page_callback($node) {
  $router_item = menu_get_item('node/' . $node->nid);
  if ($router_item['include_file']) {
    require_once DRUPAL_ROOT . '/' . $router_item['include_file'];
  }

  // This is a very, very, very bad/hackish workaround.
  if (in_array($router_item['page_callback'], array('node_page_view', 'restws_page_callback'))) {
    if (is_array($router_item['page_arguments'])) {
      $last_index = count($router_item['page_arguments']) - 1;
      $last = $router_item['page_arguments'][$last_index];
      if (property_exists($last, 'nid') && ($last->nid == $node->nid)) {
        $router_item['page_arguments'][$last_index] = $node;
      }
    }
  }

  // Call whatever function is assigned to the main node path but pass the
  // current node as an argument. This approach allows for the reuse of of Panel
  // definition acting on node/%node.
  return call_user_func_array($router_item['page_callback'], $router_item['page_arguments']);
}

Marking as major, sounds like broken functionality at the core use case of the module

Patch of the above from @jasonlttl

Looks like his changes above also incorporate #1838640: restws_page_callback() breaks workbench_moderation ?

This patch makes the issue go away for me however not when panels is installed (even after I uninstall panels theres still some issue)

Are you using panels? if so, try patch from comment #29 and if not, #40 from #1285090: Panels /node/%/edit forms

I've simplified the patch in #15
I'm not really sure if i could remove all the checks, but this seems to be working for me.
Let the testbot decide further ;-)

I've removed the change from #1838640: restws_page_callback() breaks workbench_moderation, i think it's easier to leave those two issues seperate, to hopefully get a faster fix.

I'm new to this module, just trying to evaluate it for a site, hence scanning the open issues. I don't see this problem on my site with fairly minimal other modules installed. Scanning the comments, Panels may be relevant, and I don't have that on my test site.

Looking at the most recent patch, it seems that the lines being altered relate to calling the existing router function - which could be different depending on other modules and configuration. At a guess, the router function on my site always picks the latest revision so it's fine. However some other function looks at node->vid and it breaks.

So potentially care needs to be taken - the people who have hit this bug will likely test the fix with the particular scenario where there is a bug. My suggestion is

1. Work out a scenario that causes the bug and update the issue title/description to reflect that. This will be a big help for other readers to know whether the issue is important to them.
2. Test the fix on a minimal site without the thing that causes the problem to ensure there is no regression.
3. Ideally get @gremy to test - he had a different patch, hence probably different router function (page manager??). Maybe the latest patch is good for him, or maybe there is more work to solve the problem for all uesrs.

Thanks!

Just to add to @AdamPS's comment.
I'm using this patch and #1838640: restws_page_callback() breaks workbench_moderation on a site in combination with the restws module. I'm not using panels on that site.

Just wanted to add that the patch in #19 solved the issues we were having with this scenario so +1 for #19.

#19 along with the patch in #23 from #1838640: restws_page_callback() breaks workbench_moderation is fixing these incompatibilities with Restws for me

Added replication steps per @AdamPS's comment, moving to Needs Review as this has fixed issues for multiple people and can be easily replicated by maintainers.

OK, thanks for the diligence

On patch #19

@@ -34,6 +34,11 @@ function workbench_moderation_router_item_page_callback($node) {
+  $last = $router_item['page_arguments'][$last_index];

the $last variable is never used, what is the purpose of this line?

@njbarret that line could indeed be removed. Nice find.

Tests pass, and you tested it, so you could mark it RTBC I guess.

The above mentioned patches didn't work for me.

Whenever I sent to /node/[nid]/draft, I'd still see the published version and not the draft revision.

When I investigated it, it looks like the menu handler for /node/[nid]/revisions/[revision_id]/view brought up the proper revisions.

What worked for me was to just setup a redirect to that url in workbench_moderation_node_view_draft().

@rich.yumul Your patch does not apply.

Back to RTBC for the working patch #31

Hi,

I've the same problem, but I guess it is because I use page manager. Can you confirm that Workbench cannot work along with page manager ? i.e. draft can't be seen if page manager is involved with a variant
As I've gone through the backtrace, somewhere page manager calls handlers giving them nid and not node, this way there's no possibility to show draft...

By the way, I can't figure out what the #31 patch is dealing with : the return function is the same with same arguments, so the added lines are just noise, isn't it ?

Regards,

Well, for those who has the same problem, here is a solution : https://www.drupal.org/node/2020325

I'm not using Panels and having the same issue. I applied patch #31 but the 'View draft' tab is still showing the published version while the 'Edit draft' tab allows editing the draft. I'm using Workbench Moderation 7.x-1.4.

I'm noticing this is only affecting custom fields. Anything in the Body field renders as expected. Anything in one of the page's custom fields only shows what is published even though you're viewing the 'View draft' tab. I've updated Entity API to its latest version but still not working.

This patch no longer applies to 1.x-dev. I tried to re-roll it, but it looks like this patch changes the same code modified by https://www.drupal.org/node/1838640

Since this was not committed and does not apply to 1.x-dev, updating status.

I tried one of the patches further up the thread and it didn't apply. But what was in the patch worked.

Made a new patch, may help someone.

A reroll of #31 for 7.x-3.x.

Tested with dev version and still having the same issue.
View draft will view the published version of the node.

I saw the same issue but in testing with 7.x-3.x-dev I see that the issue is no longer there. It appears that this is a duplicate of #2021903 which was fixed last month with this commit http://drupalcode.org/workbench_moderation/commit/?id=11fdb6f

Still facing the issue any update on why it is not editing the proper revision