Entity view CTools plugin doesn't load the correct revision

I suspect that the reason there is a load there is that the process of viewing the data caches so that another view in a different view mode on the same object would no longer work.

You might attempt a clone, or see if there is a way to ensure that the load loads the correct revision.

Create a panel with an entity context; add multiple versions of this pane in different view modes. They should each display correctly. Without your patch I believe they will; with your patch they might not.

Well, correctly if you're not using revisions. :)

Updated issue summary.

The patch takes out the $entityid variable which causes some issues since it's used later as the key in an array. Adding a new patch for that.

Patch in #11 works. Prior to implementing my panels pages were not showing correct version on the draft tab. After implementing all tabs show correct versions.

Patch #11 works on entity 1.3 as well.

Any idea if this patch is going to make its way into entity API? I just downloaded the latest dev release and it's not there. Before I post an issue there is there a reason this might not be accepted? It certainly seems to fix the advertised issue which I was having myself too.

I hope this is okay but I am going to move this issue to entity api since the code changes reside in that module. Additionally might get some feedback on whether is correct approach.

Here's a new patch where using the entity from context can be enabled/disabled

Hi,

maybe we should follow what ctools module is doing for node_content and do :

  $entity = isset($context->data) ? clone($context->data) : NULL;
  if (empty($entity)) {
    $block->content = '';
  }
  else {
    $block->content = entity_view($entity_type, array($entity_id => $entity), $conf['view_mode']);
  }

Here is the patch

Was copying from ctools without looking in smallest details so that is why the brackets were left there :)

This feels a bit overkill. Is there case where the data property is a NOT NULL but also not an object?

I am not 100% sure I understand what you mean. The "data" property of $context is presumably an entity object but can't be 100% certain as it is possible to change the panel arguments so can't count on it 100%. Again as I said I have copied it from ctools module without thinking in the smallest details and putting a bit of faith in it but that might be wrong.

Patch in #24 seems to work for me fine.

Patch #24 working for us as well

Somewhat related to this, CTools v7.x-1.6 includes a patch from #1820882: Make node revisions use the node_view display that makes CTools use page_manager for node revision displays if it's configured to manage node_view.

@damienMcKenna is right, this affects every revisionable entity. I ran into this today as well with the taxonomy_revision module (I'm adding panels support for it). I think this comes down to the idea that the pane renderer should accept the context data given to it rather than re-loading the entity since the context value should be the result of _load arguments from the menu hook.

@joelpittet, I agree with you on this, why do two checks if only one is needed. Attached is a re-roll with your logic in it. It'd be great to see this go in!

The patch from #31 works well for me. I have a custom CTools relations plugin which grabs the latest node revision (using Revisioning module) and create a new node context from it. Without this patch I would have to re-implement the entity_view content_type plugin to have it actually render the node from this new context in a Panels pane.

This patch introduces a change in the plugin's behavior, though I don't currently know of any code which will be affected. Maybe fall back to loading the entity based on $context-argument instead of rendering an empty string just in case? Could these ever get out of sync so that $context->argument is not set but $context->data is? If so, should we not get the entity id from $context->data?

This is related (possibly duplicate of) #2057751: revision support in ctools entity_view.

+++ b/ctools/content_types/entity_view.inc
@@ -113,8 +113,13 @@ function entity_entity_view_content_type_render($entity_type, $conf, $panel_args
-  $entity = entity_load_single($entity_type, $entity_id);
-  $block->content = entity_view($entity_type, array($entity_id => $entity), $conf['view_mode']);
+  if (!empty($context->data)) {
+    $entity = clone $context->data;
+    $block->content = entity_view($entity_type, array($entity_id => $entity), $conf['view_mode']);
+  }

Probably would be simpler to keep the fallback to the published version of the node instead of returning empty.

$entity = isset($context->data) ? clone $context->data : entity_load_single($entity_type, $entity_id);
$block->content = entity_view($entity_type, array($entity_id => $entity), $conf['view_mode']);

@paranojik yes, I also think the issues are duplicated, but the solution offered here looks more elegant.

Here is a solution from the duplicated post #2057751:

https://www.drupal.org/node/2057751#comment-11504577

Where is this issue going?

#2057751: revision support in ctools entity_view is a duplicate, but that one has been RTBC'd, not committed though.

I agree with @Gorka Guridi that this solution seems more elegant. On the other hand, the extra code that the solution in #2057751: revision support in ctools entity_view contains, has perhaps its merits.

Either way, the patch from #31 here is working for me. My patch is keeping the fallback as @Gorka Guridi suggested. It's less intrusive since it's largely keeping the original code.

This is a reroll of patch 36 , patch 36 did not apply.

I'm not sure which is better, 31 or this patch (38)
apparently patch 24 also works.

see test results.

RTBC'ing this one as the code is much simpler and cleaner than #2057751: revision support in ctools entity_view

I debugged last two days until found this was an issue in entity API :D, patch in #38 works like a charm. Ready to be integrated.

I also spent a day before understanding the issue was coming from entity.
#38 works fine!

#31 works for me with panels, entity cache

Patch #38 still applies cleanly to the latest Entity 7.x-1.10 release.

Hi, Where do I add patch #38 on latest Entity 7.x-1.10 release?
I do not see a ctools/content_types/entity_view.inc folder?

EDIT: I found it. It is on Entity module, not on Ctools. It works!
Could this patch please be committed?

greetings, Martijn