[D7] Indonesian Phone

It's better to use Drupal's code style. As one method, you can use http://pareview.sh/ .
About code - all must work right, but isn't it better to make regex configurable (for easy adaptation to ther formats)?

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsandi-racy2428375git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

1. Correct your git repository address in the issue summary. (search for git clone in below link)
2. Mention drupal version in the issue title. [D7] Indonesian Phone.

Please follow https://www.drupal.org/node/1011698 documentation.

For resolving the Pareview issues please have a look at Drupal Coding standards

You could try the followings:

• Install the Coder module
• Setup your IDE to use Drupal coding standards
• • Configuring NetBeans
  • Configuring Eclipse
  • Configuring Sublime Text
  • For complete list see this https://www.drupal.org/node/147789#ide

On Drupal.org branches are for development, so you should merge all the development into the branch 7.x-1.x
You will have to deal with releases only after you module is approved. Sandbox modules can't have releases.

Releases will be done using tags not branches.

See the naming conventions

Hi Sandiracy
I have few suggestion for your module. Please refer below for the same.

1. hook_help() is missing in this module.
2. You have used variable_set(), variable_del(), variable_get() to store, delete and retrive the regular expression in your module. It can be done by defining a constant in your module.

Thanks

Hello Sandiracy,

I installed the module and please find the coder module review comments:

indonesian_phone.module

severity: minorreview: style_button_submitLine 141: When labelling buttons, make it clear what the button does, "Submit" is too generic. [style_button_submit]
'#value' => t('Submit'),
severity: minorreview: sniffer_commenting_functioncomment_returncommentnewlineLine 157: Return comment must be on the next line [sniffer_commenting_functioncomment_returncommentnewline]
* @return string return the regex
severity: minorreview: style_trailing_spacesLine 170: There should be no trailing spaces [style_trailing_spaces]
return '

' . t('Indonesian phone module is a module that provides an indonesian phone format
severity: minorreview: style_trailing_spacesLine 171: There should be no trailing spaces [style_trailing_spaces]
field. You can change the configuration on indonesian phone administration

Thanks & Regards,
Karunakar

sadiracy, the easiest way to check for code style issues is with the pareview.sh website, http://pareview.sh/pareview/httpgitdrupalorgsandboxsandi-racy2428375git

Duplication

This sounds like a feature that should live in the existing Phone project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the Phone issue queue to discuss what you need; you likely just need to provide a patch. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

@sandiracy just like @mpdonadio mention

Phone issue queue to discuss what you need; you likely just need to provide a patch. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.
If that fails for whatever reason please get back to us and set this back to "needs review".

The reason why you would created a patch is to added the Indonesian Phone support to the Phone Module.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

As we change our project application process in #2453587: [policy, no patch] Changes to the project application review process we are not allowed to block applications base on module duplication. We can still recommend collaboration over competition, but we should not enforce it.

manual review:

1. project page is too short. Please describe what your project is doing on https://www.drupal.org/sandbox/sandi-racy/2428375 , see https://www.drupal.org/node/997024
2. As already said this looks like something that could go into the Phone project, please describe differences on the project page.
3. indonesian_phone_disable(): do not delete variables when the module is disabled, this should be done on hook_uninstall(). See https://api.drupal.org/api/drupal/modules!system!system.api.php/function...
4. indonesian_phone_change_regex(): that function doesn't really do anything, people can just call variable_set() directly? I guess it could be removed. Same for indonesian_phone_get_regex().
5. indonesian_phone_field_presave(): why is that copying around necessary? Please add a comment.
6. indonesian_phone_form(): doc block is wrong, this is not a hook. See https://www.drupal.org/coding-standards/docs#forms on how to document form building functions.
7. indonesian_phone_form(): if you use system_settings_form() here then you don't need your submit handler. See https://api.drupal.org/api/drupal/modules!system!system.module/function/...

The empty project page is a blocker right now, please fix that and the other issues. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.