Kaltura Tag Module
The Kaltura Tag module can be used to get the Kaltura items filtered by a particular tag. Multiple tags are also allowed provided they are separated by comma. If a tag is not specified, all the items will be loaded which is the default functionality of the Kaltura Module. So privileged user can enter tags using the modules configuration page.
With this module,the Kaltura partner information can be reset.
Use of Kaltura tag module
This module is helpful when importing Kaltura entries to your site. By specifying tags in the Kaltura Tag field only the tagged items will be shown up in the list of entries to be imported .
Sandbox Project Page: https://www.drupal.org/sandbox/sajiniantony/2420613
Git Link:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/sajiniantony/2420613.git kaltura_tag
cd kaltura_tag
Projects Reviewed:
https://www.drupal.org/node/2422531#comment-9605441
https://www.drupal.org/node/2423079#comment-9605379
https://www.drupal.org/node/2424163#comment-9614949
https://www.drupal.org/node/2383329#comment-9620183
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | kaltura-kaltura_tag_feature.patch | 12.02 KB | sajiniantony |
| #1 | kaltura_tag.png | 13.06 KB | sajiniantony |
Comments
Comment #1
sajiniantony commentedComment #2
sajiniantony commentedComment #3
Timusan commented@sajiniantony: Can you also include a link to your sandbox page?
Comment #4
sajiniantony commentedHi Timusan,
Included the sandbox page link.
Comment #5
darol100 commentedComment #6
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7
darol100 commentedI have run the coder module, the Pareview.sh and did not see any complains.
Manual Review
No hook_help, you should consider adding the hook_help even if display the same information as the README.txt (+)
This is a short module because it only contain 7 functions and only 88 lines of code.
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
The module is too short but I dont see any blocker issues.
Comment #8
sajiniantony commentedAs mentioned in the Coding style & Drupal API usage ,I have included hook_help in the .module file.
Comment #9
sajiniantony commentedAdded other project reviewed reference link.
Comment #10
sajiniantony commentedAdded other project reviewed reference link.
Comment #11
sajiniantony commentedAdded other project reviewed reference link.
Comment #12
sajiniantony commentedAdded review bonus tag here.
Comment #13
klausiThis sounds like a feature that should live in the existing kaltura project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the kaltura issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.
If that fails for whatever reason please get back to us and set this back to "needs review".
Comment #14
sajiniantony commentedHi klausi,
I have tested the existing Kaltura module and couldn't find the same feature which I have submitted.
As you have mentioned, I have posted an issue at Kaltura issue queue and awaiting the response. Please find the reference link; https://www.drupal.org/node/2427109
Comment #15
sajiniantony commentedHi klausi,
As per your feedback, we have posted an issue to Kaltura project 2 weeks back. But we didn't hear yet anything from the team for the Kaltura Tag feature in the existing module (please refer my above comment). We had also communicated through their contact info and not yet received any feedbacks. So please advise us how we can proceed with this module submission.
Comment #16
klausiI think the first step is to create a patch against the kaltura project introducing your changes.
Please do that and report back here.
Comment #17
PA robot commentedProject 1: https://www.drupal.org/node/2448653
Project 2: https://www.drupal.org/node/2422715
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #18
sajiniantony commentedHello Klausi,
As per the communication held with artem.kolotilkin (Ref url : https://www.drupal.org/node/2427109 ) we have completed preparing the patches
for the Kaltura Tag Feature. I am uploading the patch here(kaltura-kaltura_tag_feature.patch).
Please review and let us know your thoughts.
Comment #19
darol100 commented@klausi,
I'm going to change it to RTCB back - As we change our project application process in #2453587: [policy, no patch] Changes to the project application review process we are not allowed to block applications base on module duplication. We can still recommend collaboration over competition, but we should not enforce it. Just like you mention it before.
@sajiniantony,
I would encourage you to apply this feature to the Kaltura project instead of the module. However, if you wish to have your own module you technically could.
Comment #20
klausiLooks like sajiniantony is proceeding with a patch against the kaltura module anyway, so I think we can close this. Let me know if this is a mistake and reopen this or open a new project application if you have another project to promote.
Comment #21
avpaderno