Hi All,
Just to clarify;
I have created a module called 'Kaltura Tag' which is having a tagging feature with Kaltura existing module [Kaltura items are filtered by a particular tag]. When I have submitted this module and got reviewed the same by 'klausi', she mentioned the comment as the module already exists in the current Kaltura project. When we were downloaded and tested, couldn't get this feature in the Kaltura project. Could anyone let me know, if this feature already exists or not.
Please refer the project link which I have submitted as, https://www.drupal.org/node/2422715

The functionality of mentioned feature is as follows;
Kaltura Tag Feature
The Kaltura Tag feature can be used to get the Kaltura items filtered by a particular tag. Multiple tags are also allowed provided they are separated by comma. If a tag is not specified, all the items will be loaded which is the default functionality of the Kaltura Module. So privileged user can enter tags using the modules configuration page.
With this feature,the Kaltura partner information can be reset.

Thanks
Sajini

CommentFileSizeAuthor
#11 kaltura-katura_tag_feature.patch11.67 KBsajiniantony
#9 kaltura-kaltura_tag_feature.patch11.35 KBsajiniantony
#3 kaltura-kaltura_tag_feature.patch12.02 KBsajiniantony

Comments

sajiniantony’s picture

sajiniantony commented
Category: Feature request » Support request
Priority: Normal » Major
temkin’s picture

temkin commented

Hi sajiniantony,

I agree with klausi that it's better to have this logic integrated into the main Kaltura module rather than creating a separate module. This module hasn't been updated for a while now, but we are in the process of refactoring and getting it up to speed with latest Drupal updates. Admin UX is an important part of this process and I'd love to get your involvement into that. If you could create a patch for this module with outlined functionality I'll make sure to review it and merge into the next release.

Thanks for your interest in this module!

sajiniantony’s picture

sajiniantony commented
StatusFileSize
new kaltura-kaltura_tag_feature.patch12.02 KB

Hello Artem Kolotilkin,
Thanks for your initiative and looking into this issue!

As per your suggestion I have completed preparing the patches for the Kaltura Tag feature. I am uploading the patch here for your review (kaltura-kaltura_tag_feature.patch). I have uploaded the same in the project page (Ref url: https://www.drupal.org/node/2422715 ) as well.
Please let us know your thoughts.

sajiniantony’s picture

sajiniantony commented
Status: Active » Needs review

changed the status from Active to Needs Review

temkin’s picture

temkin commented

Hi sajiniantony,

Thanks for this patch. We will review it shortly.

sajiniantony’s picture

sajiniantony commented
Title: Kaltura Tagging feature - Clarification » Kaltura Tagging feature
Issue summary: View changes

Added the functional description.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Category: Support request » Feature request
Status: Needs review » Needs work

Patch does not apply:

$ git apply kaltura-kaltura_tag_feature_0.patch
kaltura-kaltura_tag_feature_0.patch:261: trailing whitespace.
 
error: kaltura: No such file or directory
error: kaltura_module/kaltura.module: No such file or directory

See https://www.drupal.org/node/707484 on how to create a patch.

sajiniantony’s picture

sajiniantony commented

Hi Klausi,
I have created the patch against the latest Kaltura development release available in the Kaltura project. When I was submitting, it was working fine. But now I could see the Kaltura version has been changed recently (updated on 7th April 2015) and this version contains lot of code changes. The patch which I had created also not in sync with this new version. Need to rework again and I hope, I can resubmit the patch as earliest for your review.

Thanks
Sajini

sajiniantony’s picture

sajiniantony commented
Version: 7.x-2.x-dev » 7.x-2.0
Status: Needs work » Needs review
StatusFileSize
new kaltura-kaltura_tag_feature.patch11.35 KB

Hi Klausi,

As we are still getting issues with the Kaltura latest module, couldn't proceed with our patch modifications for latest versions. But as we tested the Kaltura module with earlier version, 7.x-2.0, the patch is working fine with us. Please find the attached latest version patch herewith.

Also, I have already posted the issues with latest versions in Kaltura forum. Awaiting for the response from the team.

Meanwhile, thought of to proceed with this patch which is compatible for Kaltura 7.x-2.0 version. We will continue to work on the patch versions compatible with Kaltura other versions as well.
Please review and let me know if any issues.

Thanks
Sajini

sajiniantony’s picture

sajiniantony commented
Status: Needs review » Patch (to be ported)
sajiniantony’s picture

sajiniantony commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new kaltura-katura_tag_feature.patch11.67 KB

added the newly updated patch here.

larsmw’s picture

larsmw commented
Version: 7.x-2.0 » 7.x-3.x-dev
Priority: Major » Normal
Status: Needs review » Needs work

This should be updated to patch the 7.x-3.x branch.

larsmw’s picture

larsmw commented
Status: Needs work » Closed (outdated)