Project Description

VAOGR (Views Access Organic Group Role)
Extends the Access restriction section in views UI by allowing you to choose from organic group roles.

Screenshot

Extends the Access restriction section in views UI by allowing you to choose from organic group roles.


See the other image that list all OG roles

Project Page

VAOGR (Views Access Organic Group Role)

Git Clone

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/edutrul/2394985.git vaogr

Manual reviews of other projects

https://www.drupal.org/node/2495721#comment-9965361
https://www.drupal.org/node/2495891#comment-9966197
https://www.drupal.org/node/2495933#comment-9966399

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxedutrul2394985git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

edutrul’s picture

edutrul commented

I've just fixed! the supposedly "errors" @PA robot besides most of them are camel case issue but if you look at views plugins they are lowercase and use underscores so that wouldn't make sense. I understand that it should be with CamelCase but That's what I see in views plugins and other core plugins. Unless that the rules changed. Let me know

It needs review! thanks

mcrittenden’s picture

mcrittenden commented
Status: Needs work » Needs review

Changing status back.

I reviewed the code and couldn't find anything worth complaining about. Very nice work!

srjosh’s picture

srjosh
he/him
commented
Status: Needs review » Needs work

Latest version in the repo still reports a lot of code style errors - did you commit and push your latest?

I'd suggest removing the 'I hate checkboxes' commentary.

edutrul’s picture

edutrul commented
Status: Needs work » Needs review

Fixed doxygen issues

there are just the following that do not make much sense since class plugins and methods are in lowercase and method visibility

FILE: /var/www/drupal-7-pareview/pareview_temp/vaogr_plugin_access_role.inc
--------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------
13 | ERROR | Class name must begin with a capital letter
13 | ERROR | Class name must use UpperCamel naming without underscores
18 | ERROR | Visibility must be declared on method "access"
26 | ERROR | Method name "vaogr_plugin_access_role::get_access_callback" is
| | not in lowerCamel format, it must not contain underscores
26 | ERROR | Visibility must be declared on method "get_access_callback"
34 | ERROR | Method name "vaogr_plugin_access_role::summary_title" is not in
| | lowerCamel format, it must not contain underscores
34 | ERROR | Visibility must be declared on method "summary_title"
53 | ERROR | Method name "vaogr_plugin_access_role::option_definition" is not
| | in lowerCamel format, it must not contain underscores
53 | ERROR | Visibility must be declared on method "option_definition"
64 | ERROR | Method name "vaogr_plugin_access_role::options_form" is not in
| | lowerCamel format, it must not contain underscores
64 | ERROR | Visibility must be declared on method "options_form"
79 | ERROR | Method name "vaogr_plugin_access_role::options_validate" is not
| | in lowerCamel format, it must not contain underscores
79 | ERROR | Visibility must be declared on method "options_validate"
89 | ERROR | Method name "vaogr_plugin_access_role::options_submit" is not in
| | lowerCamel format, it must not contain underscores
89 | ERROR | Visibility must be declared on method "options_submit"
--------------------------------------------------------------------------------

Changing status to need review

rzan’s picture

rzan commented

Hi edutrul

I took a look at your module. It seems to work exactly as it should and the code seems pretty clear. Nice work.

Individual user account
Yes
No duplication
Yes. Your module seems pretty specific and I could not find anything else which does the same.
Master Branch
Yes
Licensing
Yes
3rd party assets/code
Yes. No third party code present
README.txt/README.md
Yes. You could maybe add a little more detail, but your module's function is pretty simple and the screenshot on your project page is nice.
Code long/complex enough for review
Yes. Exceeds the limits set by https://groups.drupal.org/node/195848
Secure code
Yes
Coding style & Drupal API usage
* As mentioned above, your module still has some issues with coding style, with your class definition in particular. However, you are following the conventions set out by the Views module which does not follow the coding guidelines. This makes it impossible for you to not have method name errors so I can understand the frustration. You can still defer to the Drupal standards for your class name and you should be able to add the "public" visibility declaration where applicable.

mouhammed’s picture

mouhammed commented
Status: Needs review » Needs work

I've tested this module on a clean install and It work just fine. You should fix these issues from automatic review : http://pareview.sh/pareview/httpgitdrupalorgsandboxedutrul2394985git

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Needs review

Those are most likely false positives because of Views coding standard violations and surely not application blockers - anything else that you found or should this be RTBC instead?

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Issue summary: View changes

Adding shortname to the git clone command.

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Issue summary: View changes
edutrul’s picture

edutrul commented

Works well! Please RTBC

mcrittenden’s picture

mcrittenden commented
Status: Needs review » Reviewed & tested by the community
edutrul’s picture

edutrul commented
Issue summary: View changes
edutrul’s picture

edutrul commented

Please guys! this is being RTBC for more than 4 months, please let this be a drupal project. Thanks

pravin ajaaz’s picture

pravin ajaaz commented
Assigned: edutrul » Unassigned
Priority: Normal » Critical

Review other projects and Add pareview bonus to speed up this

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.