[D7] netForum Authenticate

What's the difference with https://www.drupal.org/project/netforum_authentication ?
besides that you need to make sure you complete the following checks https://www.drupal.org/node/1587704

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

(+)Pareview.sh is showing a lot complains/errrors - http://pareview.sh/pareview/httpgitdrupalorgsandboxfsahsen2495857git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

No: Does not follow the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. You should add more helpful information about your module in the hook_help
2. Your module show some errors once the module is been enable.
3. (+)You need to change your branch name from master to 7.x-1.x (or whatever major version it actually is). For more information please visit guidelines for master branch
4. (+)Most of your errors from pareview.sh are because you are not following Drupal Coding Standards Your module looks very difficult to read since everything is just in one line.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

(+)Pareview.sh is showing a lot complains/errrors - http://pareview.sh/pareview/httpgitdrupalorgsandboxfsahsen2495857git

Your module does not follow Drupal best practice. The module is one line the module code needs to be readable.

Just like I mention

(+)Most of your errors from pareview.sh are because you are not following Drupal Coding Standards Your module looks very difficult to read since everything is just in one line.

Automatic Review

Pareview.sh

Since you organize your code now, you have a lot complains/warning/errors from the Pareview.sh

http://pareview.sh/pareview/httpgitdrupalorgsandboxfsahsen2495857git

Please fix these.

Coder Review

All these are minors complains they are not blockers.

bootstrap.php

• Line -1: @file block missing (Drupal Docs)

• Line 8: do not use mixed case (camelCase), use lower case and _
      function findFiles($directory, $extensions = []) { 

core.php

• Line -1: @file block missing (Drupal Docs)

• Line 61: do not use mixed case (camelCase), use lower case and _
      $externalId = _netauth_get_external_uid_from_username($input['name']);
  

•   Line 63: do not use mixed case (camelCase), use lower case and _
      if (($externalId || !$uid) && $sso = netauth_externalUser($input['name'], $input['pass'])) {

•   Line 103: put a space between the asterisk and the comment text
      /*$nf = new Netforum\Providers\ServiceProvider([

form.display.php

• Line -1: @file block missing (Drupal Docs)

form.menu.help.php

• Line -1: @file block missing (Drupal Docs)

form.menu.php

• Line -1: @file block missing (Drupal Docs)

• Line 24: put a space between the asterisk and the comment text
      /*$items['admin/config/netforum/auth/connectivity'] = [

helpers.php

• Line -1: @file block missing (Drupal Docs)
  

Manual Review

• Why are you using all the extensions as .php instead of .module or .inc ? In Drupal we usually use the extension .module and if you wish to separate your code into different files we use .inc. Change your files extension to either .module or .inc.
• You have set-up a lot variables, that they needs to be delete once they module is been uninstall. Check into variable_del and hook_uninstall to remove your variables once your module is been uninstall.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. +Use the Drupal API to retrieve things like a Drupal user from the Database.
2. +Follow the Drupal way of naming and using files. See Creating modules - a tutorial: Drupal 7.x. for example the way you use your module file is not valid.
3. Doc blocks are lacking or non existent in your code, or when it is there it does not list why a parameter is there or what a function does.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

See Review https://www.drupal.org/node/2495933#comment-10397501

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.