[D7] Redirect Check

Hi my friend,

Please update your description and add the following:

Git Clone

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/mr.infinity/2495221.git redirect_check

This module sounds cool. I ran it through http://pareview.sh/pareview/httpgitdrupalorgsandboxmrinfinity2495221git and it only found a spelling error.

congrats! just one spelling issue http://pareview.sh/pareview/httpgitdrupalorgsandboxmrinfinity2495221git

Review of the 7.x-1.x branch (commit 7d58bbe):

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Manual Review:

1. redirect_check_install : Check here that db_field_exists redirect and fallback in schema.There might be case that the field already exists by some other contrib.
2. Readme.txt is awesome.See tips for a good project page https://www.drupal.org/node/997024

Otherwise looks good to me.
Assigning to Ayesh to give it a final look if he has time

Thanks Naveen. I'll take a look and promote (only the project?) it tomorrow if no major issues are there.

Hi there,
I could take a real good look at the module. There are few very minor concerns, but overall, it's really well written module, specially not forgetting make it compatible with the Entity module as well.

- Module uses _redirect_check_fallback_url_validate as an element validate. Usually, element_validate handlers are individual filters. But, in this case, it relies on the other check box. A regular form validator handler would make more sense in here.

- It's not really necessary to load the redirect object in the form_alter hook. If there is a redirect object, it will be available in $form_state['build_info']['args'][0].

Otherwise looks great to me. Naveen mentioned single project promote tag here, so I'm promoting only the project. Majority of authors who got their single-project promotions get the git vetted role after some time. There's long discussion about that you can see here. Altering schema of another module, proper uninstall/install hooks, element_validate, entity alters and other implementations are just great, so I'd vote to give him the vetted role anyway. I'll leave it for Naveen and others to decide.

Thanks for your contribution, "mr.infinity"!

I have promoted the Redirect Check module to a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

I am convinced on giving the git vetted role but as per the current policy, I have requested for 2nd opinion to get the feedback from others reviewers https://groups.drupal.org/node/157669#comment-1109593 Please followup there.
Thanks!

I granted vetted status. While the lines of code may be low, it is dense code and shows API usage in several areas (schemas, forms, entities). This adequately demonstrates knowledge of Drupal to obtain vetted status.