This is a Drupal Commerce Payment Gateway for the Commerce Account Balance
module. You can use your account balance for paying in the normal Drupal
Commerce checkout process, not only the simple purchase mode provided by
Commerce Account Balance module.

Sandbox project:
https://www.drupal.org/node/2488894/

Drupal version: 7.x

Git download link:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/thomas73/2488894.git

Comments

thomas73’s picture

Issue summary: View changes
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxthomas732488894git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

thomas73’s picture

Status: Needs work » Needs review

Automated test issues fixed.

mr_infinity’s picture

Automated Review

[pareview.sh / drupalcs / coder] Test are ok

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[No: Does not follow] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements.]
Coding style & Drupal API usage
  1. It seems that in your code there are hooks implemented. You should document this with: Implements hook_submit_form_validate(). for example.
  2. Using language_none does not work for translatable fields, it's probably best to use field_get_items or entity_metadata_wrapper.
Other
  1. On the project page more information is needed, read more about this.

This review uses the Project Application Review Template.

mr_infinity’s picture

You will need to give this ticket a [D7] title.

Pravin Ajaaz’s picture

Title: Commerce Account Balance Payment Gateway » [D7] Commerce Account Balance Payment Gateway

Manual Review :

  • In .module file please correct "implementation" typo. This might be minor but there are modules which are annotation based.
  • In .inc consider adding @param and @return values for you own functions other than hooks.
  • As mr.inifinity pointed, You should change the "LANGUAGE NONE" (it makes things untranslatable).
Pravin Ajaaz’s picture

Status: Needs review » Needs work
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.