[D7] FP Photo Gallery

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxpcrats332390765git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Automated Review

Issues identified by the automated tool need to be addressed:

http://pareview.sh/pareview/httpgitdrupalorgsandboxpcrats332390765git

Manual Review

Individual user account: Yes: Follows the guidelines for individual user accounts.

No duplication Yes: Does not cause module duplication and/or fragmentation.

Master Branch No: Does not follow the guidelines for master branch.

Licensing Yes: Follows the licensing requirements.

3rd party assets/code: No: Does not follow the guidelines for 3rd party assets/code.

README.txt/README.md: No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for reviewNo: Does not follow the guidelines for project length and complexity. I understand this is meant as a wrapper module, but it really doesn't provide any functionality at all. Basically users have to create a view by themselves and add manually ALOT of static html code to the view header and things like that. That does not leverage any Drupal functionality but also makes this extremely confusing for the end user. If I would add a module of this type I would rather bet on a feature module that provides the view and all remaining components out of the box. I would also really avoid "theming" inside views and leverage more the Drupal theming layer.

Secure codeYes: Meets the security requirements.

Coding style & Drupal API usage

Like said before, overall the concept of this module could be addressed better.

• (*) It basically leverages no Drupal API's except for hook_views_pre_view and hook__views_post_execute only to add js files.
• (*) The paths in both hooks are hardcoded to a specific view id, which considering the view is not even provided by the module is poor design. Could consider at least a configuration screen to set a variable for this so it's not hardcoded.
• Naming conventions in variables like $a and lack of inline comments don't help the developer to understand what's being done (e.g on hook_views_pre_view)
• (*) Third party js included in the module as state above and the actual js code is full of hardcoded paths and selectors which can be seen in the README.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2404127

Project 2: https://www.drupal.org/node/2390855

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2390855

Project 2: https://www.drupal.org/node/2404127

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Automated errors

http://pareview.sh/pareview/httpgitdrupalorgsandboxpcrats332390765git

That are surely not application blockers, please do a real manual review.

Removing review bonus tag, no reviews linked in the issue summary.

The files should be in the repository root, please remove the fp_photo_gallery folder.

Fixed git clone command (there was no "master" branch).

Automated Review

The automated review of your project by PAReview has found some trivial formatting issues with your code. As coding standards make sure projects are coded in a consistent style we ask you to please have a look at the report and try to fix them.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: Does not inform about duplication and/or fragmentation.

There is already exists a lot of gallery modules for Drupal. Here is a list with those I am aware of:

• bootstrap_gallery
• gallery
• galleryformatter
• juicebox
• photos
• plus_gallery
• swipe_photo_gallery

The way I interpret § 1.2 of the Project application checklist, is that we only block if the "differences between your modules are not too fundamental for patching an existing one".

However, users need to be informed about possible functional overlap. This should be made is section with the heading "Similar projects and how they are different" on the project's project page.

1. acknowledges the existence of similar projects; and
2. briefly explain how they are different.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

No: Does not follow the guidelines for 3rd party assets/code.

The module comes bundled with prev.png and next.png which appears to be third party assets Copyright 2010 Alexander Kiselev (from the Gentleface.com free icons set).
Third party code/assets is not generally allowed on Drupal.org and should be deleted.
These particular assets are made available under the Creative Commons Attribution Non-commercial No derivatives license. This also violates policy, since all assets hosted on Drupal.org must be licensed under the GPL V2+ license.
This policy is described in the 3rd party libraries and content on Drupal.org. It also appears in the Drupal Git Repository Usage policy you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

The "Requirements" section should list all the modules/libraries required to install the project. For libraries not on Drupal.org, it should also list where to find them.
It lists jQuery UI as a requirement, but not where to find it. Also, the following modules/libraries are missing from the list of requirements: Views UI, Chaos Tools, Libraries, hoverIntent, jquery.easing.js. While some of these are secondary dependencies, all dependencies should be listed so that prospective users knows up-front what they need to get in order to install the project.

I was not able to follow the instructions in the "Configuration" section to actally create a slideshow. It is of course possible that is a problem on my side (i.e. I'm too stupid), but at least to me, it is not clear what is meant by sentences like: "reformat the view output as: <div><a href="[uri]">[field_photo]</a></div>. It would be better to be told in what component in the Views UI you do this reformatting.
Also, it is not clear if the 80x120px thumbnail is portrait or landscape format. If the module has the limitation that only portrait format is supported, that limitation should be documented in README.txt - I hate finding out that a module is useless to me after spending hours setting it up correctly.
At the moment, I also think this project is too hard to use and also too poorly documented to be useful for ordinary site builders.

Please take a moment to make your README.txt follow the guidelines for in-project documentation and the README.txt Template.

Code long/complex enough for review

Yes: Mariginally follows the guidelines for project length and complexity.

The project is just passing the bare minumum (120 lines and 5 functions). It have no configuration settings and no user input, so it does not demonstrate applicant's ability to work with the Drupal API.

Secure code

Yes: Meets the security requirements. However, since the module has no user input, and no interaction with the database, it is too bare bones to demonstrate that the applicant knows how to write secure code.

Coding style & Drupal API usage

As it is a very small module, there is not much to review. However, the link "Problems with the gallery? This default link will send you home" does not work correctly if the Drupal site root/home is in a subdirectory (http://www.example.com/sub/). In that case, clicking it takes the user to "http://www.example.com/" and not the Drupal home.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.