Entering a user not existing in system on "Authored By", you will get a message like this:

2 problems:
#1, You don't know what is "no entities".
#2, "Authoring Information" on right side is closed. No errors highlighting on screen. FIXED by #2346773: Details form element should open when there are errors on child elements

CommentFileSizeAuthor
#4 2359711-test-only.patch2.64 KBameymudras
#4 D8-Improve_Error_Message_of_Authored_By-2359711.patch2.25 KBameymudras
#3 2359711-test-only.patch2.64 KBameymudras
#1 D8-Improve_Error_Message_of_Authored_By-2359711.patch2.25 KBSagar Ramgade
authored-by.jpg77.3 KBdroplet
#9 2359711-9.patch4.89 KBameymudras
#9 2359711-test-only-9.patch2.64 KBameymudras
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sagar Ramgade’s picture

Sagar Ramgade CreditAttribution: Sagar Ramgade commented
Status: Active » Needs review
FileSize
D8-Improve_Error_Message_of_Authored_By-2359711.patch2.25 KB

Hi,

Attached is the patch for problem #1, Second one ideally needs to be taken care by $form_state->setError(). I am not sure if any issue already posted for setError.

Status: Needs review » Needs work

The last submitted patch, 1: D8-Improve_Error_Message_of_Authored_By-2359711.patch, failed testing.

ameymudras’s picture

ameymudras CreditAttribution: ameymudras as a volunteer commented
FileSize
2359711-test-only.patch2.64 KB

Updated tests according to the above patch.

Regarding the second point i don't think it would be feasible

ameymudras’s picture

ameymudras CreditAttribution: ameymudras as a volunteer commented
FileSize
2359711-test-only.patch2.64 KB
D8-Improve_Error_Message_of_Authored_By-2359711.patch2.25 KB

Sorry for the above one

ameymudras’s picture

ameymudras CreditAttribution: ameymudras as a volunteer commented
Status: Needs work » Needs review

The last submitted patch, 4: 2359711-test-only.patch, failed testing.

The last submitted patch, 4: D8-Improve_Error_Message_of_Authored_By-2359711.patch, failed testing.

droplet’s picture

droplet CreditAttribution: droplet commented
Related issues: +#2493957: Add back errors support to native HTML5 details tag
ameymudras’s picture

ameymudras CreditAttribution: ameymudras as a volunteer commented
FileSize
2359711-9.patch4.89 KB
2359711-test-only-9.patch2.64 KB

Corrected test and test patch

ameymudras’s picture

ameymudras CreditAttribution: ameymudras as a volunteer commented

The last submitted patch, 9: 2359711-9.patch, failed testing.

The last submitted patch, 9: 2359711-test-only-9.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
Status: Needs review » Needs work
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
Issue tags: +Needs tests

Status: Needs work » Needs review

ameymudras queued 4: 2359711-test-only.patch for re-testing.

ameymudras queued 4: D8-Improve_Error_Message_of_Authored_By-2359711.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2359711-test-only.patch, failed testing.

The last submitted patch, 4: D8-Improve_Error_Message_of_Authored_By-2359711.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
Issue tags: -accesibility +Accessibility

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Issue tags: +Usability
andrewmacpherson’s picture

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commented
Issue summary: View changes

Problem 2 from the issue summary was fixed by #2346773: Details form element should open when there are errors on child elements.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.