Entering a user not existing in system on "Authored By", you will get a message like this:

2 problems:
#1, You don't know what is "no entities".
#2, "Authoring Information" on right side is closed. No errors highlighting on screen.

Files: 
CommentFileSizeAuthor
#9 2359711-9.patch4.89 KBameymudras
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 106,872 pass(es), 6 fail(s), and 0 exception(s). View
#9 2359711-test-only-9.patch2.64 KBameymudras
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 106,906 pass(es), 3 fail(s), and 0 exception(s). View

Comments

Sagar Ramgade’s picture

Status: Active » Needs review
FileSize
2.25 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 87,181 pass(es), 3 fail(s), and 0 exception(s). View

Hi,

Attached is the patch for problem #1, Second one ideally needs to be taken care by $form_state->setError(). I am not sure if any issue already posted for setError.

Status: Needs review » Needs work

The last submitted patch, 1: D8-Improve_Error_Message_of_Authored_By-2359711.patch, failed testing.

ameymudras’s picture

FileSize
2.64 KB

Updated tests according to the above patch.

Regarding the second point i don't think it would be feasible

ameymudras’s picture

FileSize
2.64 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] Unable to apply patch 2359711-test-only_0.patch. Unable to apply patch. See the log in the details link for more information. View
2.25 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] Unable to apply patch D8-Improve_Error_Message_of_Authored_By-2359711_0.patch. Unable to apply patch. See the log in the details link for more information. View

Sorry for the above one

ameymudras’s picture

Status: Needs work » Needs review

The last submitted patch, 4: 2359711-test-only.patch, failed testing.

The last submitted patch, 4: D8-Improve_Error_Message_of_Authored_By-2359711.patch, failed testing.

droplet’s picture

ameymudras’s picture

FileSize
4.89 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 106,872 pass(es), 6 fail(s), and 0 exception(s). View
2.64 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 106,906 pass(es), 3 fail(s), and 0 exception(s). View

Corrected test and test patch

ameymudras’s picture

The last submitted patch, 9: 2359711-9.patch, failed testing.

The last submitted patch, 9: 2359711-test-only-9.patch, failed testing.

mgifford’s picture

Status: Needs review » Needs work
mgifford’s picture

Issue tags: +Needs tests

Status: Needs work » Needs review

ameymudras queued 4: 2359711-test-only.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2359711-test-only.patch, failed testing.

The last submitted patch, 4: D8-Improve_Error_Message_of_Authored_By-2359711.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mgifford’s picture

Issue tags: -accesibility +accessibility

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.