[D7] Block export widget

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxeugef2350637git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Whilst manually reviewing your code in the repository viewer, I came across the following:

• Line 75 - "Returns list of blocks that could not be exported." I'm not sure that this makes sense in this context. It sounds like some sort of error reporting, rather than where a user chose not to allow the export of certain blocks. It would be better worded "Returns list of blocks which have been excluded from export."

Otherwise I think the code looks good. Module installs cleanly and admin interface is simple. Export works. Pity that it can not do CSS/JS, but maybe that can be a feature request for the 2.0 version!

So really the only thing is clearing up that comment on line 75.

That comment is surely not an application blocker, any other issues you found or should this be rtbc instead?

Looks good so.

Tried it on one of my sites. Installs cleanly and works just fine.

Looks good.....

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Review of the 7.x-1.x branch (commit c5f8788):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/block_export_widget.admin.inc
  ---------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ---------------------------------------------------------------------------
   20 | ERROR | Separate the @ingroup and @see sections by a blank line.
  ---------------------------------------------------------------------------
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. "drupal_alter('block_export_widget_excluded_blocks', $excluded_blocks);": Hooks that are provided by a module should be documented in MODULENAME.api.php, see http://drupal.org/node/161085#api_php . Also elsewhere for the other drupal_alter() and module_invoke_all() calls.
2. Your whole config is in one variable which is loaded into memory on every single page request. If there are many exports this could have a negative performance impact. Not sure how realistic that problem is, your own DB table would be a solution in this case.
3. block_export_widget_admin_configure_form_submit(): do not document $form and $form_state here, see https://www.drupal.org/coding-standards/docs#forms

But that are not application blockers, so ...

Thanks for your contribution, Eugene!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.