Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Og comments access allow you to manage comment access in Og group context.
It comes with 2 new og permission :
- Post comments
- Edit any comments
With these 2 permissions, you can now restrict comment posting on group.
You can also allow particular OG role to modify all group comments.
There 2 permissions overwrite the global Drupal permission in the group context
Project page
https://www.drupal.org/sandbox/ttournie/2348941
Git
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ttournie/2348941.git og_comments_access
Automated Review
http://pareview.sh/pareview/httpgitdrupalorgsandboxttournie2348941git
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedProject 1: https://www.drupal.org/node/2349403
Project 2: https://www.drupal.org/node/2344695
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
ttournie CreditAttribution: ttournie commentedComment #4
ttournie CreditAttribution: ttournie commentedComment #5
PA robot CreditAttribution: PA robot commentedProject 1: https://www.drupal.org/node/2344695
Project 2: https://www.drupal.org/node/2349403
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6
ziomizar CreditAttribution: ziomizar commentedHi ttournie,
Thanks for your module.
The project dont have a default branch see the documentation on setting a default branch.
I haven't tried your module but i have a question, In og_comments_access() line 47, you use
Why change the global $user variable? can't you change the $account variable? Something like this:
Comment #7
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
ttournie CreditAttribution: ttournie commentedSorry for the delay and thanks ziomizar.
It was an silly mistake and I have fixed it now.
Comment #9
ttournie CreditAttribution: ttournie commentedComment #10
evucan CreditAttribution: evucan as a volunteer commenteddelete please
Comment #11
evucan CreditAttribution: evucan as a volunteer and commentedAutomated Review
Passed.
Manual Review
I can see that you have incorporated the comment of the previous reviewer. The rest of the code seems fine.
This review uses the Project Application Review Template.
Comment #12
evucan CreditAttribution: evucan as a volunteer commentedComment #13
ttournie CreditAttribution: ttournie commentedThank you @evucan
Comment #14
apadernoThank you for your contribution!
I am going to update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thank you to the dedicated reviewer(s) as well.
Comment #15
ttournie CreditAttribution: ttournie commentedThank you !