This very simple module adds a responsive class to all tables on your site, and uses the Zurb Responsive tables library to display all table content on mobiles without needing to hide columns.

  • Doesn't break responsive layouts
  • Doesn't unnecessarily hide data
  • Still lets you compare rows

Works for all tables on a site.

https://www.drupal.org/sandbox/chriscollins405/2345459

Example Page
http://zurb.com/playground/projects/responsive-tables/index.html

Git Clone
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/chriscollins405/2345459.git zurb_responsive_tables

Comments

Collins405’s picture

Collins405 commented
Title: [7] Zurb Responsive Tables » [D7] Zurb Responsive Tables
Issue summary: View changes
Collins405’s picture

Collins405 commented
Issue summary: View changes
PA robot’s picture

PA robot commented
Status: Active » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxchriscollins405234545...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Collins405’s picture

Collins405 commented
Status: Needs work » Needs review

Fixed all automated formatting errors. Filed for re-review.

gaurav.pahuja’s picture

gaurav.pahuja commented
Issue summary: View changes

Fixing GIT clone command.

gaurav.pahuja’s picture

gaurav.pahuja commented
Status: Needs review » Needs work

Can you please let me know the major differences between your module and Responsive Tables?

https://www.drupal.org/project/responsive_tables

Collins405’s picture

Collins405 commented

The Responsive Tables module works by choosing a priority for columns, and then as the screen size is reduced, the columns with less priority are actually hidden, which isn't great, as you are actually hiding content from your mobile users.

With this module the first column is "pinned" to the left of the table, and all other columns are available in a scrollable table.

This means you never have to hide any information for mobile/tablet users.

A similar module is foo table , which handles responsive tables in a completely different way again.

I believe that either foo table, or the zurb libraries i have used are much better ways of handling responsive tables, rather than the responsive tables module.

Collins405’s picture

Collins405 commented
Status: Needs work » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

Please add the differences to the existing module to the project page, so that people can make an educted decision which module to use. See also https://www.drupal.org/node/997024

Collins405’s picture

Collins405 commented
Status: Needs work » Needs review

@klausi Thanks, module page updated with similar modules, longer description, and project image.

darol100’s picture

darol100 commented

@Collins405,

I ran some testing on your module using the coder module and I got this error.

responsive-tables.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]

Please add a comment block in you responsive-tables.js with some useful information and this should be solve.

darol100’s picture

darol100 commented
Status: Needs review » Needs work
Collins405’s picture

Collins405 commented
Status: Needs work » Needs review

Thanks, have added @file doc to js files, and set to needs review again.

darol100’s picture

darol100 commented
Status: Needs review » Needs work

Since you added a new block comments now you got this error.

FILE: /var/www/drupal-7-pareview/pareview_temp/js/responsive-tables.js
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
5 | ERROR | There must be exactly one blank line after the file comment
--------------------------------------------------------------------------------

http://pareview.sh/pareview/httpgitdrupalorgsandboxchriscollins405234545...

Please correct this error.

Collins405’s picture

Collins405 commented
Status: Needs work » Needs review

Ah of course, thanks mate. All sorted now

Collins405’s picture

Collins405 commented
Status: Needs review » Reviewed & tested by the community
darol100’s picture

darol100 commented
Assigned: Unassigned » darol100
Status: Reviewed & tested by the community » Needs review

@ChrisCollins405

IMHO, Please don't RTBC your own issues, see the workflow: https://www.drupal.org/node/532400.

I will revise it tonight and if everything is good I will change it back to RTBC.

darol100’s picture

darol100 commented
Assigned: darol100 » Unassigned
Status: Needs review » Reviewed & tested by the community

@ChrisCollins405

According to Coder... You still have this error....

responsive-tables.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]

However, you have in your code the Block comment.

I did not see any other errors. So I will change it to RTBC.

Thank you for your contribution

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Category: Support request » Task
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)
Issue tags: +PAreview: single application approval
Code too short
This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

This module certainly is very easy to use, and we're happy to promote it by itself, but we cannot grant "git vetted user" status for such a short module.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

Ok let's do so - I don't think we need a maintainer response for that?

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, Collins405!

I promoted this to a full project, https://www.drupal.org/project/zurb_responsive_tables

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Collins405’s picture

Collins405 commented

Thanks guys. I certainly have plans to increase the amount of code in this module to add a config page to target specific tables. Will I need to resubmit the project for review once it has more than 120 lines/5 functions?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.