[D7] Setup countries

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@acaster, thank you for your work and contribution.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. None.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

(*) May be: Does not cause module duplication and fragmentation. User can easily setup country list with Countries module, how this module is different? Please describe the differences to existing project on your project page and follow https://www.drupal.org/node/997024. IMHO, please change your module name as it does not match with your module functionality.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

(*) No: Follows the guidelines for in-project documentation and the README Template. There is no info on how to use or configure this, or how it works.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

(*) No. If "no", list security issues identified.

1. I added country list field in my article content type and then added <script>alert("XSS");</script>|<script>alert("XSS");</script> under Whitelist of the country.
   
   
   
2. Now I'm going to add new node for Article content type and choose this value:
   
   
   
3. Once I clicked on save button, it shows me following popup:
   
   
   
   This is vulnerable to XSS exploits. Every time If I choose this, will get a nasty javascript popup. You need to sanitize this before rendering, make sure to read https://www.drupal.org/node/28984 again.

Coding style & Drupal API usage

1. (*) As I througly tested this module functionality I am still unclear how admin/config/setup_countrygetlist form and country list form comes with content type field are different. If both are same then they are not sync yet and if both are separate then what is the use of Country blacklist form. As regarding this no where is mention so it confused me as I checked Zimbabwe from Country blacklist form but is unchecked on content type field form. Also I am getting following warning every time, need to fix.
   
   
   
2. Add configure = admin/config/setup_countrygetlist in your .info file to make it directly accessible from module page.
3. hook_help() is missing in your module.
4. (+) You should create separate permission for admin/config/setup_countrygetlist page instead of using default administer site configuration. Also you should keep this form in separate admin.inc file.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Thanks Again!

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2336221

Project 2: https://www.drupal.org/node/2320107

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.