[D7] Addressfield Coordinates

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2336221

Project 2: https://www.drupal.org/node/2320107

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review:

• stitchz_social_login_addin.moduleL#239
  function stitchz_social_login_addin_get_user_identities($account) {
  Replace db_query with D7 database Api.
• stitchz_social_login_addin.moduleL#290
  function stitchz_social_login_addin_format_provider_list(
  This could be replaced with a theme function & template file for markup. All the logic could go into preprocessor functions.

1. on line 146 in addressfield_coordinates.module, i see

$person_coordinates_children = t('%name', array('%name' => $person_coordinates_children));

No need to use wildcards here, just use:

$person_coordinates_children = t($person_coordinates_children);

2. Is the foreach loop really necessary on line 24? If so, what does it do? Seems like you are doing your work in the foreach loop on line 50
3. On line 127, you think using static would be better? So instead of

  $addressfields = &drupal_static(__FUNCTION__);

  if (!isset($addressfields)) {

You may use

  if (!isset($addressfields)) {
    static $addressfields;

4. On line 29 you already defined $language var, so on line 83, unnecessary to use LANGUAGE_NONE again.

A screenshot of the enhanced address field would be good.

@bekirdag why did you set review bonus tag? No links to reviews were provided in the issue summary.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.